Add location field in DNS authorization resource. #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add location field in DNS authorization resource * Fixed the provider version of the updated config --------- Co-authored-by: Hamza Hassan <[email protected]> [upstream:f60f2e6424a7eb3746a8b8cfff9fccceaa272ab7] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
roaks3
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-f60f2e6424a7eb3746a8b8cfff9fccceaa272ab7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new field
locationinDnsAuthorizationresource in certificate managers. The field will default to global in case it's unset.This is pretty much similar to what happened in GoogleCloudPlatform/magic-modules#7825, I used this PR as a reference to make a state_migration to avoid breaking changes.
The resource does not yet support non global instances, but once it does, we will add a new example with a different location.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9968