Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured that beta runs in TeamCity use only beta paths #1976

Conversation

modular-magician
Copy link
Collaborator

Made sure that all packages used in beta configurations use google-beta in their path instead of google. I also added tests that I think would catch this issue in the future for sweepers, since that's the problem at hand - I'm also not as confident about how to add tests for the other packages.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#10025

* Ensured that beta runs in TeamCity use only beta paths

* Added tests for sweeper package path

[upstream:d9c78713a1229b452f880d271f76f8923fa9f76b]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner February 21, 2024 23:48
@modular-magician modular-magician requested review from iyabchen and removed request for a team February 21, 2024 23:48
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 3cb7ee9 into GoogleCloudPlatform:main Feb 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant