Object lock feature implementation for Storage #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Early implementation of bucket object lock setting. * Complete implementation of object lock for buckets. * Compelete implementation, waiting for allowlist. * Tests pass against test environment. * Fixes bug in object test. * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket_object.go Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket_object.go Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket_test.go.erb Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket_object.go Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket.go.erb Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Updates from review comments * Update mmv1/third_party/terraform/services/storage/resource_storage_bucket_object.go Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/website/docs/r/storage_bucket_object.html.markdown Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Removing non-deterministic date from test * Removing unused variable * fixing nested_customer_encryption anchor link --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> [upstream:4f308083373dd8a5b409e42fbe3e7fdd561853c8] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
shuyama1
and removed request for
a team
modular-magician
deleted the
downstream-pr-4f308083373dd8a5b409e42fbe3e7fdd561853c8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the Object Lock feature, which allows for setting retention policies on objects.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9363