Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge gap between Terraform and API for AlloyDB #1494

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Bridge gap between Terraform and API for AlloyDB #1494

merged 1 commit into from
Sep 25, 2023

Conversation

modular-magician
Copy link
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

This PR contains multiple changes for AlloyDB cluster, instance, and backup. It adds all the attributes which were missing in Terraform but were present in REST API for these resources and the corresponding tests.

Release Note Template for Downstream PRs (will be copied)

alloydb: added additional fields to `google_alloydb_instance` and `google_alloydb_backup`

Derived from GoogleCloudPlatform/magic-modules#8781

@modular-magician
Bridge gap between Terraform and API for AlloyDB (#8781)
5fba4ed 
* Add display name to backup

* Add alll the fields for backup

* Fix indentation

* Fix indentation

* Fix documentation and  attribute type

* Add attributes for cluster and instance with tests

* Remove annotations and displayName as not supported by GET API

* Misc

* Mark queryInsightsConfig as default_from_api instead of its sub-fields

* Mark Backup type as default_from_api

* Delete ignore_only section in alloydb_backup_basic

* Re-run tests

* Comment out tests failing due to networking service bug

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner September 25, 2023 16:47
@modular-magician modular-magician requested review from iyabchen and removed request for a team September 25, 2023 16:47
@modular-magician modular-magician merged commit 9eaf13d into GoogleCloudPlatform:main Sep 25, 2023
5 checks passed
@modular-magician modular-magician deleted the downstream-pr-9838777ae9e75d79e67a401129f9783473be1fa5 branch November 18, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyabchen iyabchen Awaiting requested review from iyabchen iyabchen is a code owner automatically assigned from GoogleCloudPlatform/terraform-validator-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician