Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new labels model to more resources (part 1) #1450

Conversation

modular-magician
Copy link
Collaborator

  1. Handle the case that the labels field is inside a flatten object (google_bigquery_job)
  2. Make effective_labels immutable if labels filed is immutable
  3. Apply the labels model to more MMV1 resources

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#8950

* Apply new labels model to more resources (part 1)

* Handle labels field inside flatten object

* Fix the tests for datasource

* Fix typo

* Fix typo

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner September 15, 2023 23:11
@modular-magician modular-magician requested review from melinath and removed request for a team September 15, 2023 23:11
@modular-magician modular-magician merged commit 819e80c into GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0 Sep 15, 2023
3 of 5 checks passed
@modular-magician modular-magician deleted the downstream-pr-0ef602f678611b77172a342e8e2980633054ed01 branch November 18, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant