Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for make it mine and deploy via cloudbuild trigger #96

Merged

Conversation

satyam-chhatrala-google
Copy link
Contributor

@satyam-chhatrala-google satyam-chhatrala-google commented Mar 29, 2024

Make it Mine prototype aims to provide tooling which enables customers to take a deployed Jump Start Solution(JSS) and create a workspace for them so they can continue developing, modifying and redeploying the solution. This aids users to continue their learning journey and engagement with GCP.
This PR is raised to enable support for Make-it-mine (MIM) and CI/CD pipeline for terraform-genai-knowledge-base JSS solution via cloudbuild_mim trigger. Here is the entire guide on steps followed to add this support: https://docs.google.com/document/d/17HtsFR09A2-tn3rU4xLMBWSCfsl4mem487XvfWeInXE/edit?tab=t.0#heading=h.2z2xx08nzw0h

@kweinmeister
Copy link
Contributor

/gcbrun

@davidcavazos
Copy link
Collaborator

/gcbrun

@NimJay
Copy link
Contributor

NimJay commented Apr 6, 2024

Hi @satyam-chhatrala-google, thanks for this pull-request.

  1. Could you please provider more context into these changes (i.e., add a more descriptive pull-request description)? (Mostly for future maintainers and reviewers.)
  2. Also, how do you plan on testing these changes (e.g., manually)?
  3. Could you also please let us know when this is ready for us to try out inside Console (in non-production)?

@github-actions github-actions bot added feature and removed feature labels Apr 8, 2024
@satyam-chhatrala-google
Copy link
Contributor Author

satyam-chhatrala-google commented Apr 8, 2024

  1. Could you please provider more context into these changes (i.e., add a more descriptive pull-request description)? (Mostly for future maintainers and reviewers.)
    Updated Description.
  2. Also, how do you plan on testing these changes (e.g., manually)?
    Yes. We plan on testing these changes manually by deploying solution on Pantheon.
  3. Could you also please let us know when this is ready for us to try out inside Console (in non-production)?
    Yes, we will let you know once the changes to enable MIM for this solution are available in staging.

@github-actions github-actions bot added feature and removed feature labels Apr 8, 2024
@davidcavazos davidcavazos merged commit bb0c209 into GoogleCloudPlatform:main Apr 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants