Skip to content
This repository has been archived by the owner on Jan 14, 2023. It is now read-only.

Change ZVAL_DESTRUCTOR to zval_ptr_dtor to run on PHP 7.3 #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beberlei
Copy link

To compile on PHP 7.3, the deprecated ZVAL_DESTRUCTOR macro must be exchanged with zval_ptr_dtor.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@beberlei
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@carlos-granados
Copy link

Any idea when this might be merged? It's been 3 months and it is stopping apps using PHP 7.3 and 7.4 from working

@carlos-granados
Copy link

Now that PHP8 is out, it is ridiculous that this has not been merged. Is anyone actually maintaining this?

@hakimdjabri
Copy link

Is anyone maintaining this? we can wait for the merge in 2022 !!

@sleenen
Copy link

sleenen commented Mar 3, 2022

PING

Merge this and release to PECL... please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants