feat: support crc32c checksum validation #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecretVersions created after July 2021 all have a checksum either generated by the end user when calling AddSecretVersion or server side by the Secret Manager API when initially written. https://cloud.google.com/secret-manager/docs/data-integrity This change adds an additional crc32c validation to catch possible data corruption. Note this will not catch corruption that may occur downstream of the provider (i.e. by the driver process, linux tmpfs mount, or the process consuming the secret).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SecretVersions created after July 2021 all have a checksum either
generated by the end user when calling AddSecretVersion or server
side by the Secret Manager API when initially written.
https://cloud.google.com/secret-manager/docs/data-integrity
This change adds an additional crc32c validation to catch possible
data corruption. Note this will not catch corruption that may occur
downstream of the provider (i.e. by the driver process, linux tmpfs
mount, or the process consuming the secret).