Inherit env vars in sudo uses. #807
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @msuozzo, thanks for proposing this change. I need a bit time and research to understand the impact of this change. If you could help me understand the following questions, I would be able to approve it much faster:
|
|
Discussed internally. This looks good to me. |
jinglundong
approved these changes
Sep 2, 2022
|
do you know what the CI issue could be here? doesn't seem to be resolving |
|
Seems like there's no links to check the kokoro status. I'm also seeing that |
|
To move forward, you may look for the corresponding kokoro workflow to this repo. (I'm working on a high priority bug, so couldn't dive too deep into this today. ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.