Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs for Terraform CLI example #78

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Improve docs for Terraform CLI example #78

merged 5 commits into from
Jan 11, 2024

Conversation

gibbleyg
Copy link
Contributor

No description provided.

@gibbleyg gibbleyg requested a review from linhlam-kc January 10, 2024 21:24
@gibbleyg
Copy link
Contributor Author

/gcbrun

linhlam-kc
linhlam-kc approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@linhlam-kc linhlam-kc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the typo is fixed. I also added a minor recommendation in the README file.

examples/terraform/complex_cli_only/README.md Outdated Show resolved Hide resolved
examples/terraform/complex_cli_only/README.md Outdated Show resolved Hide resolved
@gibbleyg
Copy link
Contributor Author

/gcbrun

@gibbleyg gibbleyg changed the title Inprove docs for Terraform CLI example Improve docs for Terraform CLI example Jan 11, 2024
@gibbleyg gibbleyg merged commit bdd85d6 into master Jan 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linhlam-kc linhlam-kc linhlam-kc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gibbleyg @linhlam-kc