Fix issues with vcr status and logs #9987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
c2thorn
approved these changes
Feb 14, 2024
|
I could be wrong, but it seems we'll mistakenly mark the VCR status as |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
tdbhacks
pushed a commit
to tdbhacks/magic-modules
that referenced
this pull request
Feb 23, 2024
* Fix issues with vcr status and logs * Report success if recording succeeds, not replaying after recording
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Mar 6, 2024
* Fix issues with vcr status and logs * Report success if recording succeeds, not replaying after recording
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
Apr 19, 2024
* Fix issues with vcr status and logs * Report success if recording succeeds, not replaying after recording
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
May 2, 2024
* Fix issues with vcr status and logs * Report success if recording succeeds, not replaying after recording
pengq-google
pushed a commit
to pengq-google/magic-modules
that referenced
this pull request
May 21, 2024
* Fix issues with vcr status and logs * Report success if recording succeeds, not replaying after recording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with replaying after recording logs getting improperly uploaded and test state being improperly reported.
Release Note Template for Downstream PRs (will be copied)