-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set GOOGLE_TPU_V2_VM_RUNTIME_VERSION for VCR tests #9788
Conversation
/gcbrun |
2 similar comments
/gcbrun |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 11 insertions(+), 10 deletions(-)) |
272ba6c
to
c1fdeab
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 11 insertions(+), 10 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy |
Rerun these tests in REPLAYING mode to catch issues
|
c1fdeab
to
013ad90
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
)" This reverts commit 812bc97.
Part of hashicorp/terraform-provider-google#16957
A couple of tpu v2 vm tests failed with the capacity error.
To fix the issue, the service team suggested to use a test vm runtime version. But this runtime version is only for testing and should not be exposed to public. https://buganizer.corp.google.com/issues/306250637#comment10
So an environment variable is used to store the value.
I created a secret for this environment variable and set it up for VCR tests in this PR.
Release Note Template for Downstream PRs (will be copied)