Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GOOGLE_TPU_V2_VM_RUNTIME_VERSION for VCR tests #9788

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Jan 9, 2024

Part of hashicorp/terraform-provider-google#16957

A couple of tpu v2 vm tests failed with the capacity error.

Error: Error waiting to create Vm: Error waiting for Creating Vm: Error code 8, message: There is no more capacity in the zone "us-central1-c"

To fix the issue, the service team suggested to use a test vm runtime version. But this runtime version is only for testing and should not be exposed to public. https://buganizer.corp.google.com/issues/306250637#comment10

So an environment variable is used to store the value.

I created a secret for this environment variable and set it up for VCR tests in this PR.

Release Note Template for Downstream PRs (will be copied)


@zli82016
Copy link
Member Author

zli82016 commented Jan 9, 2024

/gcbrun

2 similar comments
@zli82016
Copy link
Member Author

/gcbrun

@zli82016
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 11 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 4 files changed, 22 insertions(+), 17 deletions(-))

@zli82016 zli82016 force-pushed the tpu-v2-vm-tests branch 3 times, most recently from 272ba6c to c1fdeab Compare January 10, 2024 00:19
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 11 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 4 files changed, 23 insertions(+), 17 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3335
Passed tests 2996
Skipped tests: 338
Affected tests: 1

Click here to see the affected service packages
all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@zli82016 zli82016 requested review from a team and trodge and removed request for a team January 10, 2024 17:14
@zli82016 zli82016 changed the title Use tpu v2 vm test runtime version to fix capacity issue Set GOOGLE_TPU_V2_VM_RUNTIME_VERSION for VCR tests Jan 10, 2024
@zli82016 zli82016 merged commit 812bc97 into main Jan 12, 2024
16 checks passed
@zli82016 zli82016 deleted the tpu-v2-vm-tests branch January 12, 2024 20:28
bskaplan pushed a commit to bskaplan/magic-modules that referenced this pull request Jan 17, 2024
kylase pushed a commit to yuanchuankee/magic-modules that referenced this pull request Jan 21, 2024
zli82016 added a commit to zli82016/magic-modules that referenced this pull request Apr 29, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants