-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin tensorflow_version on TPU Node Full Test so that the test passes #9786
Pin tensorflow_version on TPU Node Full Test so that the test passes #9786
Conversation
Hello! I am a robot. It looks like you are a: @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 insertion(+), 4 deletions(-)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
Hello, @zeleena , did you run the test |
Hi @zli82016. I ran the test locally. On its own it fails with
which seems unrelated to the fix here. Instead, it seems related to the I had to modify the networking aspects to mirror the basic example. It may still hit capacity errors, but that is retry-able, and when it can get the capacity, the test passes
This fix won't address the capacity errors, but it will address the random set of Tensorflow versions bug. |
Thanks for testing it locally. The reason for bootstrapped network error could be that the environment variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pin
tensorflow_version
on TPU Node Full Test so that the test passes. Fixes hashicorp/terraform-provider-google#16703Because
mmv1/products/tpu/Node.yaml
already usestpu_node_full.tf.erb
for documentation andtpu_node_full_test.tf.erb
for tests, this change shouldn't affect public documentation since we are just updatingtpu_node_full_test.tf.erb
.Release Note Template for Downstream PRs (will be copied)