Added service team review request support #9681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melinath
force-pushed
the
b-295224401
branch
from
2f4dc9a to
a0f253a
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 5 deletions(-)) |
melinath
force-pushed
the
b-295224401
branch
from
a0f253a to
8951923
Compare
melinath
requested review from
ScottSuarez and
trodge
and removed request for
roaks3
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
ScottSuarez
requested changes
Dec 21, 2023
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
ScottSuarez
approved these changes
Dec 21, 2023
|
Small notice, unit tests are failing |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
kapreus
pushed a commit
to kapreus/magic-modules
that referenced
this pull request
Jan 2, 2024
* Initial work to support requesting service team reviews * Initial implementation of PR requests for service teams * Added test team * Added issue labeler dependency * Fixed build errors * Cleanup * Added request-service-reviewers to generate-diffs * Added unit tests * Removed test team * Tweaked variable name to be more explicit * Fixed ordering expectations in tests * Clarified which variables are sets
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
May 2, 2024
* Initial work to support requesting service team reviews * Initial implementation of PR requests for service teams * Added test team * Added issue labeler dependency * Fixed build errors * Cleanup * Added request-service-reviewers to generate-diffs * Added unit tests * Removed test team * Tweaked variable name to be more explicit * Fixed ordering expectations in tests * Clarified which variables are sets
pengq-google
pushed a commit
to pengq-google/magic-modules
that referenced
this pull request
May 21, 2024
* Initial work to support requesting service team reviews * Initial implementation of PR requests for service teams * Added test team * Added issue labeler dependency * Fixed build errors * Cleanup * Added request-service-reviewers to generate-diffs * Added unit tests * Removed test team * Tweaked variable name to be more explicit * Fixed ordering expectations in tests * Clarified which variables are sets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed b/295224401