Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nightly vcr cassettes update #9678

Merged
merged 9 commits into from
Dec 21, 2023
Merged

nightly vcr cassettes update #9678

merged 9 commits into from
Dec 21, 2023

Conversation

shuyama1
Copy link
Member

@shuyama1 shuyama1 commented Dec 19, 2023 •
edited
Loading

Created a cloud build trigger vcr-nightly that runs .ci/gcb-vcr-nightly.yml at 12am daily. .ci/scripts/go-plus/vcr-cassette-update/vcr_cassette_update.sh reuse most of the code in VCR-tester

Test runs:

  • Full test run: all tests passed in replaying, no tests rerun in recording
  • Sample run: run firewall tests replaying + recording

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1 shuyama1 requested review from trodge and melinath December 20, 2023 00:05
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

melinath
melinath approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@melinath melinath left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me & fairly straightforward / similar to the test_terraform_vcr.sh file; probably not easy to test without merging (but shouldn't impact anything else if there are issues.)

@shuyama1
Copy link
Member Author

seems reasonable to me & fairly straightforward / similar to the test_terraform_vcr.sh file; probably not easy to test without merging (but shouldn't impact anything else if there are issues.)

Tested it with the gcb trigger set to branch vcr_nightly for now. results can be found here

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1 shuyama1 merged commit 93b77a9 into main Dec 21, 2023
10 checks passed
@shuyama1 shuyama1 deleted the vcr_nightly branch December 21, 2023 23:31
kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
@shuyama1 @kapreus
nightly vcr cassettes update (GoogleCloudPlatform#9678)
e81571e 
* nightly vcr cassettes update setup

* fix comment + delete cassettes to test recording

* trigger full test run

* update comments

* update

* changed cassette source

* activate service account first

* updated cassette folder

* new SA for vcr-nightly
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@shuyama1 @balanaguharsha
nightly vcr cassettes update (GoogleCloudPlatform#9678)
1df558c 
* nightly vcr cassettes update setup

* fix comment + delete cassettes to test recording

* trigger full test run

* update comments

* update

* changed cassette source

* activate service account first

* updated cassette folder

* new SA for vcr-nightly
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@shuyama1 @pengq-google
nightly vcr cassettes update (GoogleCloudPlatform#9678)
dff32ad 
* nightly vcr cassettes update setup

* fix comment + delete cassettes to test recording

* trigger full test run

* update comments

* update

* changed cassette source

* activate service account first

* updated cassette folder

* new SA for vcr-nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

@trodge trodge trodge approved these changes

@ScottSuarez ScottSuarez ScottSuarez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shuyama1 @modular-magician @melinath @ScottSuarez @trodge