-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in containerattached when removing admin_groups or admin_users. #9647
Fix crash in containerattached when removing admin_groups or admin_users. #9647
Conversation
Hello! I am a robot. It looks like you are a: @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 130 insertions(+), 15 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAttachedCluster_update |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need to format the test file. You can run gofmt -w -s mmv1/third_party/terraform/services/containerattached/resource_container_attached_cluster_update_test.go
from the MM root to do that.
Thanks for the review! I've formatted the file. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 130 insertions(+), 15 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy |
Rerun these tests in REPLAYING mode to catch issues
|
…ers. (GoogleCloudPlatform#9647) * Fix crash in containerattached when removing admin_groups or admin_users. * Format test file.
…ers. (GoogleCloudPlatform#9647) * Fix crash in containerattached when removing admin_groups or admin_users. * Format test file.
…ers. (GoogleCloudPlatform#9647) * Fix crash in containerattached when removing admin_groups or admin_users. * Format test file.
Fixes hashicorp/terraform-provider-google#16784
Add checks to the custom flattener for the
authorization
field to ensure data is available before trying to use it.Release Note Template for Downstream PRs (will be copied)