Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in containerattached when removing admin_groups or admin_users. #9647

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

hankfreund
Copy link
Member

Fixes hashicorp/terraform-provider-google#16784

Add checks to the custom flattener for the authorization field to ensure data is available before trying to use it.

Release Note Template for Downstream PRs (will be copied)

containerattached: fixed crash when updating a cluster to remove `admin_users` or `admin_groups`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 130 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 2 files changed, 130 insertions(+), 15 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3296
Passed tests 2958
Skipped tests: 337
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAttachedCluster_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerAttachedCluster_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to format the test file. You can run gofmt -w -s mmv1/third_party/terraform/services/containerattached/resource_container_attached_cluster_update_test.go from the MM root to do that.

@hankfreund
Copy link
Member Author

Thanks for the review! I've formatted the file.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 130 insertions(+), 15 deletions(-))
Terraform Beta: Diff ( 2 files changed, 130 insertions(+), 15 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3297
Passed tests 2959
Skipped tests: 337
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@rileykarson rileykarson merged commit 1bb86d9 into GoogleCloudPlatform:main Dec 20, 2023
11 checks passed
kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
…ers. (GoogleCloudPlatform#9647)

* Fix crash in containerattached when removing admin_groups or admin_users.

* Format test file.
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…ers. (GoogleCloudPlatform#9647)

* Fix crash in containerattached when removing admin_groups or admin_users.

* Format test file.
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
…ers. (GoogleCloudPlatform#9647)

* Fix crash in containerattached when removing admin_groups or admin_users.

* Format test file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform-provider-google_v5.9.0_x5 plugin crashed! on resource google_container_attached_cluster update
3 participants