Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "The version field should be under configmanagement instead of under oci" #9645

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

shuyama1
Copy link
Member

Reverts #9587

gkehub2: added field `version` under `configmanagement` instead of a child field `oci` in `google_gke_hub_feature` resource (revert)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field fleet_default_member_config.configmanagement.version within resource google_gke_hub_feature was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 28 deletions(-))
Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 28 deletions(-))
TF Conversion: Diff ( 1 file changed, 11 insertions(+), 11 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_hub_feature (33 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_hub_feature" "primary" {
  fleet_default_member_config {
    configmanagement {
      config_sync {
        oci {
          version = # value needed
        }
      }
    }
  }
}

@shuyama1 shuyama1 requested a review from zli82016 December 14, 2023 19:20
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for reverting it.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3293
Passed tests 2956
Skipped tests: 337
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants