Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WorkloadALTSConfig in google_container_cluster (Beta) #9638

Merged
merged 10 commits into from
Dec 15, 2023

Conversation

AshZhang
Copy link
Member

Fixes hashicorp/terraform-provider-google#16793.

WorkloadALTSConfig is a parameter in the beta GKE Cluster API used to configure authentication for Directpath connections. This PR adds support to the google-beta provider.

Release Note Template for Downstream PRs (will be copied)

container: added `workload_alts_config` field to `google_container_cluster` resource (beta)

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 6 insertions(+))
Terraform Beta: Diff ( 3 files changed, 179 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3293
Passed tests 2952
Skipped tests: 338
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withWorkloadALTSConfig|TestAccDataprocJobIamPolicy|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerCluster_withWorkloadALTSConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 6 insertions(+))
Terraform Beta: Diff ( 3 files changed, 179 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3293
Passed tests 2955
Skipped tests: 337
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withWorkloadALTSConfig

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withWorkloadALTSConfig[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just some small changes requested

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 6 insertions(+))
Terraform Beta: Diff ( 3 files changed, 142 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (272 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  workload_alts_config {
    enable_alts = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 6 insertions(+))
Terraform Beta: Diff ( 3 files changed, 142 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (272 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  workload_alts_config {
    enable_alts = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3294
Passed tests 2955
Skipped tests: 337
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerCluster_withWorkloadALTSConfig|TestAccDataprocJobIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withWorkloadALTSConfig[Debug log]
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@AshZhang AshZhang deleted the workload-alts branch December 15, 2023 20:32
kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
…GoogleCloudPlatform#9638)

* Add support for WorkloadALTSConfig in google_container_cluster

* Fix issues

* Make enable_alts within workload_alts_config required and force-send in JSON

* Update documentation

* Make acceptance test network & subnet names unique

* Remove extra test config

* Fix spacing
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…GoogleCloudPlatform#9638)

* Add support for WorkloadALTSConfig in google_container_cluster

* Fix issues

* Make enable_alts within workload_alts_config required and force-send in JSON

* Update documentation

* Make acceptance test network & subnet names unique

* Remove extra test config

* Fix spacing
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
…GoogleCloudPlatform#9638)

* Add support for WorkloadALTSConfig in google_container_cluster

* Fix issues

* Make enable_alts within workload_alts_config required and force-send in JSON

* Update documentation

* Make acceptance test network & subnet names unique

* Remove extra test config

* Fix spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for WorkloadALTSConfig in google_container_cluster (Beta)
3 participants