-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WorkloadALTSConfig in google_container_cluster (Beta) #9638
Conversation
Hello! I am a robot. It looks like you are a: @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withWorkloadALTSConfig|TestAccDataprocJobIamPolicy|TestAccDataSourceGoogleServiceAccountIdToken_impersonation |
Rerun these tests in REPLAYING mode to catch issues
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withWorkloadALTSConfig |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just some small changes requested
mmv1/third_party/terraform/services/container/resource_container_cluster.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/container/resource_container_cluster_test.go.erb
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 6 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
workload_alts_config {
enable_alts = # value needed
}
}
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 6 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
workload_alts_config {
enable_alts = # value needed
}
}
|
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withWorkloadALTSConfig|TestAccDataprocJobIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
…GoogleCloudPlatform#9638) * Add support for WorkloadALTSConfig in google_container_cluster * Fix issues * Make enable_alts within workload_alts_config required and force-send in JSON * Update documentation * Make acceptance test network & subnet names unique * Remove extra test config * Fix spacing
…GoogleCloudPlatform#9638) * Add support for WorkloadALTSConfig in google_container_cluster * Fix issues * Make enable_alts within workload_alts_config required and force-send in JSON * Update documentation * Make acceptance test network & subnet names unique * Remove extra test config * Fix spacing
…GoogleCloudPlatform#9638) * Add support for WorkloadALTSConfig in google_container_cluster * Fix issues * Make enable_alts within workload_alts_config required and force-send in JSON * Update documentation * Make acceptance test network & subnet names unique * Remove extra test config * Fix spacing
Fixes hashicorp/terraform-provider-google#16793.
WorkloadALTSConfig is a parameter in the beta GKE Cluster API used to configure authentication for Directpath connections. This PR adds support to the google-beta provider.
Release Note Template for Downstream PRs (will be copied)