Add support for enable_relay field to advanced_datapath_observability_config

[siwiutki]

This field is an alternative to relay_mode field in advanced_datapath_observability_config to enable Relay.

https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/projects.locations.clusters#Cluster.AdvancedDatapathObservabilityConfig

Release Note Template for Downstream PRs (will be copied)

container: added support for `enable_relay` field to `advanced_datapath_observability_config`
container: deprecated support for `relay_mode` field in `advanced_datapath_observability_config` in favor of `enable_relay` field, `relay_mode` field will be removed in upcoming releases

Fixes b/304971620

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 73 insertions(+))
Terraform Beta: Diff ( 4 files changed, 73 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 73 insertions(+))
Terraform Beta: Diff ( 4 files changed, 73 insertions(+))

[modular-magician]

Tests analytics

Total tests: 183
Passed tests 170
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 131 insertions(+))
Terraform Beta: Diff ( 4 files changed, 131 insertions(+))

[modular-magician]

Tests analytics

Total tests: 183
Passed tests 170
Skipped tests: 12
Affected tests: 1

Click here to see the affected service packages

• container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 144 insertions(+))
Terraform Beta: Diff ( 4 files changed, 144 insertions(+))

[modular-magician]

Tests analytics

Total tests: 184
Passed tests 170
Skipped tests: 12
Affected tests: 2

Click here to see the affected service packages

• container

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfigOld|TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfigOld[Error message] [Debug log]
TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 169 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 169 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 183
Passed tests 169
Skipped tests: 12
Affected tests: 2

Click here to see the affected service packages

• container

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig|TestAccContainerCluster_withMonitoringConfig

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig[Debug log]
TestAccContainerCluster_withMonitoringConfig[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 176 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 4 files changed, 176 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 183
Passed tests 0
Skipped tests: 12
Affected tests: 171

Click here to see the affected service packages

• container

Action taken

Found 171 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withHostMaintenancePolicy|TestAccContainerNodePool_withEnablePrivateNodesToggle|TestAccContainerNodePool_withMultiNicNetworkConfig|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerNodePool_threadsPerCore|TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings|TestAccContainerNodePool_localNvmeSsdBlockConfig|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_withoutConfidentialBootDisk|TestAccContainerNodePool_withNetworkConfig|TestAccContainerNodePool_withConfidentialNodes|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerNodePool_ephemeralStorageLocalSsdConfig|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_customPlacementPolicy|TestAccContainerNodePool_fastSocket|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_autoscaling|TestAccContainerClusterDatasource_zonal|TestAccContainerNodePool_compactPlacement|TestAccContainerNodePool_enableQueuedProvisioning|TestAccContainerNodePool_gcfsConfig|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_totalSize|TestAccContainerNodePool_resize|TestAccContainerNodePool_concurrent|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_version|TestAccContainerNodePool_gvnic|TestAccContainerNodePool_withCgroupMode|TestAccContainerNodePool_withConfidentialBootDisk|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerCluster_additional_pod_ranges_config_on_create|TestAccContainerNodePool_nodeLocations|TestAccContainerCluster_withPrivateClusterConfigPrivateEndpointSubnetwork|TestAccContainerCluster_additional_pod_ranges_config_on_update|TestAccContainerCluster_withPrivateEndpointSubnetwork|TestAccContainerCluster_with_PodCIDROverprovisionDisabled|TestAccContainerCluster_autopilot_minimal|TestAccContainerCluster_stackType_withSingleStack|TestAccContainerCluster_stackType_withDualStack|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withTaintsUpdate|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withMachineAndDiskUpdate|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_basic|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withLoggingVariantUpdates|TestAccContainerCluster_withEnablePrivateEndpointToggle|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withoutConfidentialBootDisk|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerNodePool_withReservationAffinity|TestAccContainerCluster_autopilot_net_admin|TestAccContainerCluster_customPlacementPolicy|TestAccContainerCluster_withLoggingVariantInNodePool|TestAccContainerCluster_withConfidentialBootDisk|TestAccContainerCluster_withConfidentialBootDiskNodeConfig|TestAccContainerCluster_withNodePoolConflictingNameFields|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_withWorkloadALTSConfig|TestAccContainerCluster_network|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withTPUConfig|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_backend|TestAccContainerCluster_withNodePoolCIA|TestAccContainerCluster_withSecurityPostureConfig|TestAccContainerCluster_withProtectConfig|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withFleetConfig|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withLoggingVariantInNodeConfig|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withNodeConfigReservationAffinitySpecific|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodeConfigReservationAffinity|TestAccContainerCluster_withIPv4Error|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withIncompatibleMasterVersionNodeVersion|TestAccContainerCluster_withGatewayApiConfig|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withDNSConfig|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_withVersion|TestAccContainerCluster_withNodePoolDefaults|TestAccContainerCluster_withPrivateClusterConfigGlobalAccessEnabledOnly|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withLoggingVariantUpdates|TestAccContainerCluster_withGcpPublicCidrsAccessEnabledToggle|TestAccContainerCluster_regional|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccContainerCluster_withPrivateClusterConfigBasic|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withEnableKubernetesBetaAPIsOnExistingCluster|TestAccContainerCluster_withTpu|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withEnableKubernetesBetaAPIs|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withCostManagementConfig|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig|TestAccContainerCluster_withExternalIpsConfig|TestAccContainerCluster_withMeshCertificatesConfig|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_withAutopilotNetworkTags|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerClusterCustomServiceAccount_withAutopilot|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withMonitoringConfig|TestAccContainerCluster_autoprovisioningDefaultsManagement|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_withMultiNetworking|TestAccContainerCluster_withFQDNNetworkPolicy|TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey|TestAccContainerCluster_withBinaryAuthorizationEvaluationModeClassic|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_withBinaryAuthorizationEvaluationModeAutopilot|TestAccContainerEngineVersions_filtered|TestAccContainerCluster_nodeAutoprovisioningNetworkTags|TestAccContainerCluster_withNotificationConfig|TestAccContainerEngineVersions_basic|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withBinaryAuthorizationEnabledBool|TestAccContainerCluster_withDeletionProtection|TestAccContainerCluster_withAddons|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_misc|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withFilteredNotificationConfig|TestAccContainerCluster_basic|TestAccContainerClusterDatasource_regional

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withHostMaintenancePolicy[Error message] [Debug log]
TestAccContainerNodePool_withEnablePrivateNodesToggle[Error message] [Debug log]
TestAccContainerNodePool_withMultiNicNetworkConfig[Error message] [Debug log]
TestAccContainerNodePool_withSoleTenantConfig[Error message] [Debug log]
TestAccContainerNodePool_threadsPerCore[Error message] [Debug log]
TestAccContainerCluster_autoprovisioningDefaultsUpgradeSettings[Error message] [Debug log]
TestAccContainerNodePool_localNvmeSsdBlockConfig[Error message] [Debug log]
TestAccContainerNodePool_ephemeralStorageConfig[Error message] [Debug log]
TestAccContainerNodePool_withNodeConfigScopeAlias[Error message] [Debug log]
TestAccContainerNodePool_withoutConfidentialBootDisk[Error message] [Debug log]
TestAccContainerNodePool_withNetworkConfig[Error message] [Debug log]
TestAccContainerNodePool_withConfidentialNodes[Error message] [Debug log]
TestAccContainerNodePool_shieldedInstanceConfig[Error message] [Debug log]
TestAccContainerNodePool_ephemeralStorageLocalSsdConfig[Error message] [Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator[Error message] [Debug log]
TestAccContainerNodePool_customPlacementPolicy[Error message] [Debug log]
TestAccContainerNodePool_fastSocket[Error message] [Debug log]
TestAccContainerNodePool_regionalClusters[Error message] [Debug log]
TestAccContainerNodePool_withManagement[Error message] [Debug log]
TestAccContainerNodePool_regionalAutoscaling[Error message] [Debug log]
TestAccContainerNodePool_autoscaling[Error message] [Debug log]
TestAccContainerClusterDatasource_zonal[Error message] [Debug log]
TestAccContainerNodePool_compactPlacement[Error message] [Debug log]
TestAccContainerNodePool_enableQueuedProvisioning[Error message] [Debug log]
TestAccContainerNodePool_gcfsConfig[Error message] [Debug log]
TestAccContainerNodePool_withGPU[Error message] [Debug log]
TestAccContainerNodePool_totalSize[Error message] [Debug log]
TestAccContainerNodePool_resize[Error message] [Debug log]
TestAccContainerNodePool_concurrent[Error message] [Debug log]
TestAccContainerNodePool_012_ConfigModeAttr[Error message] [Debug log]
TestAccContainerNodePool_version[Error message] [Debug log]
TestAccContainerNodePool_gvnic[Error message] [Debug log]
TestAccContainerNodePool_withCgroupMode[Error message] [Debug log]
TestAccContainerNodePool_withConfidentialBootDisk[Error message] [Debug log]
TestAccContainerNodePool_withLinuxNodeConfig[Error message] [Debug log]
TestAccContainerNodePool_maxPodsPerNode[Error message] [Debug log]
TestAccContainerCluster_additional_pod_ranges_config_on_create[Error message] [Debug log]
TestAccContainerNodePool_nodeLocations[Error message] [Debug log]
TestAccContainerCluster_withPrivateClusterConfigPrivateEndpointSubnetwork[Error message] [Debug log]
TestAccContainerCluster_additional_pod_ranges_config_on_update[Error message] [Debug log]
TestAccContainerCluster_withPrivateEndpointSubnetwork[Error message] [Debug log]
TestAccContainerCluster_with_PodCIDROverprovisionDisabled[Error message] [Debug log]
TestAccContainerCluster_autopilot_minimal[Error message] [Debug log]
TestAccContainerCluster_stackType_withSingleStack[Error message] [Debug log]
TestAccContainerCluster_stackType_withDualStack[Error message] [Debug log]
TestAccContainerNodePool_withSandboxConfig[Error message] [Debug log]
TestAccContainerNodePool_withTaintsUpdate[Error message] [Debug log]
TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges[Error message] [Debug log]
TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges[Error message] [Debug log]
TestAccContainerCluster_withIPAllocationPolicy_specificSizes[Error message] [Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig[Error message] [Debug log]
TestAccContainerNodePool_withMachineAndDiskUpdate[Error message] [Debug log]
TestAccContainerNodePool_withReservationAffinitySpecific[Error message] [Debug log]
TestAccContainerNodePool_basicWithClusterId[Error message] [Debug log]
TestAccContainerNodePool_basic[Error message] [Debug log]
TestAccContainerNodePool_withNodeConfig[Error message] [Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates[Error message] [Debug log]
TestAccContainerCluster_withEnablePrivateEndpointToggle[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaults[Error message] [Debug log]
TestAccContainerCluster_withoutConfidentialBootDisk[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioning[Error message] [Debug log]
TestAccContainerNodePool_withReservationAffinity[Error message] [Debug log]
TestAccContainerCluster_autopilot_net_admin[Error message] [Debug log]
TestAccContainerCluster_customPlacementPolicy[Error message] [Debug log]
TestAccContainerCluster_withLoggingVariantInNodePool[Error message] [Debug log]
TestAccContainerCluster_withConfidentialBootDisk[Error message] [Debug log]
TestAccContainerCluster_withConfidentialBootDiskNodeConfig[Error message] [Debug log]
TestAccContainerCluster_withNodePoolConflictingNameFields[Error message] [Debug log]
TestAccContainerCluster_deleteExclusionWindow[Error message] [Debug log]
TestAccContainerCluster_deleteMaintenanceExclusionOptions[Error message] [Debug log]
TestAccContainerCluster_updateMaintenanceExclusionOptions[Error message] [Debug log]
TestAccContainerCluster_withWorkloadALTSConfig[Error message] [Debug log]
TestAccContainerCluster_network[Error message] [Debug log]
TestAccContainerCluster_withMaintenanceExclusionOptions[Error message] [Debug log]
TestAccContainerCluster_withRecurringMaintenanceWindow[Error message] [Debug log]
TestAccContainerCluster_withNodePoolNodeConfig[Error message] [Debug log]
TestAccContainerCluster_withMaintenanceWindow[Error message] [Debug log]
TestAccContainerCluster_withTPUConfig[Error message] [Debug log]
TestAccContainerCluster_withMaintenanceExclusionWindow[Error message] [Debug log]
TestAccContainerCluster_withNodePoolMultiple[Error message] [Debug log]
TestAccContainerCluster_withNodePoolUpdateVersion[Error message] [Debug log]
TestAccContainerCluster_withNodePoolAutoscaling[Error message] [Debug log]
TestAccContainerCluster_backend[Error message] [Debug log]
TestAccContainerCluster_withNodePoolCIA[Error message] [Debug log]
TestAccContainerCluster_withSecurityPostureConfig[Error message] [Debug log]
TestAccContainerCluster_withProtectConfig[Error message] [Debug log]
TestAccContainerCluster_withNodePoolResize[Error message] [Debug log]
TestAccContainerCluster_withNodePoolBasic[Error message] [Debug log]
TestAccContainerCluster_withFleetConfig[Error message] [Debug log]
TestAccContainerCluster_withReleaseChannelEnabled[Error message] [Debug log]
TestAccContainerCluster_withNodeConfig[Error message] [Debug log]
TestAccContainerCluster_withLoggingVariantInNodeConfig[Error message] [Debug log]
TestAccContainerCluster_withSandboxConfig[Error message] [Debug log]
TestAccContainerCluster_withWorkloadMetadataConfig[Error message] [Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinitySpecific[Error message] [Debug log]
TestAccContainerCluster_withNodeConfigShieldedInstanceConfig[Error message] [Debug log]
TestAccContainerCluster_withNodeConfigReservationAffinity[Error message] [Debug log]
TestAccContainerCluster_withIPv4Error[Error message] [Debug log]
TestAccContainerCluster_updateVersion[Error message] [Debug log]
TestAccContainerCluster_withIncompatibleMasterVersionNodeVersion[Error message] [Debug log]
TestAccContainerCluster_withGatewayApiConfig[Error message] [Debug log]
TestAccContainerCluster_withMasterAuthorizedNetworksConfig[Error message] [Debug log]
TestAccContainerCluster_withNodeConfigScopeAlias[Error message] [Debug log]
TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot[Error message] [Debug log]
TestAccContainerCluster_withBootDiskKmsKey[Error message] [Debug log]
TestAccContainerCluster_withDNSConfig[Error message] [Debug log]
TestAccContainerCluster_withIntraNodeVisibility[Error message] [Debug log]
TestAccContainerCluster_withVersion[Error message] [Debug log]
TestAccContainerCluster_withNodePoolDefaults[Error message] [Debug log]
TestAccContainerCluster_withPrivateClusterConfigGlobalAccessEnabledOnly[Error message] [Debug log]
TestAccContainerCluster_regionalWithNodePool[Error message] [Debug log]
TestAccContainerCluster_withMasterAuthorizedNetworksDisabled[Error message] [Debug log]
TestAccContainerCluster_withLoggingVariantUpdates[Error message] [Debug log]
TestAccContainerCluster_withGcpPublicCidrsAccessEnabledToggle[Error message] [Debug log]
TestAccContainerCluster_regional[Error message] [Debug log]
TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock[Error message] [Debug log]
TestAccContainerCluster_withPrivateClusterConfigBasic[Error message] [Debug log]
TestAccContainerCluster_withTelemetryEnabled[Error message] [Debug log]
TestAccContainerCluster_withEnableKubernetesBetaAPIsOnExistingCluster[Error message] [Debug log]
TestAccContainerCluster_withTpu[Error message] [Debug log]
TestAccContainerCluster_withResourceUsageExportConfig[Error message] [Debug log]
TestAccContainerCluster_withEnableKubernetesBetaAPIs[Error message] [Debug log]
TestAccContainerCluster_errorNoClusterCreated[Error message] [Debug log]
TestAccContainerCluster_withAdvancedDatapath[Error message] [Debug log]
TestAccContainerCluster_withEnableKubernetesAlpha[Error message] [Debug log]
TestAccContainerCluster_withCostManagementConfig[Error message] [Debug log]
TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion[Error message] [Debug log]
TestAccContainerCluster_withMonitoringConfigAdvancedDatapathObservabilityConfig[Error message] [Debug log]
TestAccContainerCluster_withExternalIpsConfig[Error message] [Debug log]
TestAccContainerCluster_withMeshCertificatesConfig[Error message] [Debug log]
TestAccContainerCluster_withDatabaseEncryption[Error message] [Debug log]
TestAccContainerCluster_withAutopilotNetworkTags[Error message] [Debug log]
TestAccContainerCluster_errorAutopilotLocation[Error message] [Debug log]
TestAccContainerClusterCustomServiceAccount_withAutopilot[Error message] [Debug log]
TestAccContainerCluster_withAutopilot[Error message] [Debug log]
TestAccContainerCluster_withFlexiblePodCIDR[Error message] [Debug log]
TestAccContainerCluster_regionalWithNodeLocations[Error message] [Debug log]
TestAccContainerCluster_withMonitoringConfig[Error message] [Debug log]
TestAccContainerCluster_autoprovisioningDefaultsManagement[Error message] [Debug log]
TestAccContainerCluster_withSoleTenantGroup[Error message] [Debug log]
TestAccContainerCluster_withIdentityServiceConfig[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsShieldedInstance[Error message] [Debug log]
TestAccContainerCluster_withLoggingConfig[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType[Error message] [Debug log]
TestAccContainerCluster_withWorkloadIdentityConfig[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskSizeGb[Error message] [Debug log]
TestAccContainerCluster_networkingModeRoutes[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsDiskType[Error message] [Debug log]
TestAccContainerCluster_withShieldedNodes[Error message] [Debug log]
TestAccContainerCluster_withMultiNetworking[Error message] [Debug log]
TestAccContainerCluster_withFQDNNetworkPolicy[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningDefaultsBootDiskKmsKey[Error message] [Debug log]
TestAccContainerCluster_withBinaryAuthorizationEvaluationModeClassic[Error message] [Debug log]
TestAccContainerCluster_withAutoscalingProfile[Error message] [Debug log]
TestAccContainerCluster_withBinaryAuthorizationEvaluationModeAutopilot[Error message] [Debug log]
TestAccContainerEngineVersions_filtered[Error message] [Debug log]
TestAccContainerCluster_nodeAutoprovisioningNetworkTags[Error message] [Debug log]
TestAccContainerCluster_withNotificationConfig[Error message] [Debug log]
TestAccContainerEngineVersions_basic[Error message] [Debug log]
TestAccContainerCluster_withNetworkPolicyEnabled[Error message] [Debug log]
TestAccContainerCluster_withAuthenticatorGroupsConfig[Error message] [Debug log]
TestAccContainerCluster_withBinaryAuthorizationEnabledBool[Error message] [Debug log]
TestAccContainerCluster_withDeletionProtection[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccContainerCluster_withMasterAuthConfig_NoCert[Error message] [Debug log]
TestAccContainerCluster_misc[Error message] [Debug log]
TestAccContainerCluster_withILBSubsetting[Error message] [Debug log]
TestAccContainerCluster_withConfidentialNodes[Error message] [Debug log]
TestAccContainerCluster_withFilteredNotificationConfig[Error message] [Debug log]
TestAccContainerCluster_basic[Error message] [Debug log]
TestAccContainerClusterDatasource_regional[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field monitoring_config.advanced_datapath_observability_config MinItems went from 0 to 0 on google_container_cluster - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 175 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 4 files changed, 175 insertions(+), 8 deletions(-))

[modular-magician]

Tests analytics

Total tests: 183
Passed tests 171
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages

• container

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[siwiutki]

I'm not sure if I understand what's the breaking change detected here. MinItems did not change, though MaxItems did. I believe change to MaxItems will not be breaking, as implementation only used the 0-index element of AdvancedDatapathObservabilityConfig and this config, defined as TypeList, was never meant to have more than 1 item.

Therefore I think it's fine to merge it in the current state.

[siwiutki]

@trodge can you take a look at this PR again?