Only set enabled bool if evaluation mode is unspecified

[rmoriar1]

Remove enable_binary_authorization conditional, this was missed in #8784.

Fixes hashicorp/terraform-provider-google#16759

container: fixed an issue in which migrating from the deprecated Binauthz enablement bool to the new evaluation mode enum inadvertently caused two cluster update events, instead of none.

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[rmoriar1]

The provider crashed while running the VCR tests in REPLAYING mode Please fix it to complete your PR View the build log

Unrelated? I don't see any of the affected tests failing

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 12 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 1 file changed, 12 insertions(+), 27 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3292
Passed tests 2953
Skipped tests: 338
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerCluster_withBinaryAuthorizationEnabledBool

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withBinaryAuthorizationEnabledBool[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 13 insertions(+), 28 deletions(-))
Terraform Beta: Diff ( 1 file changed, 13 insertions(+), 28 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3292
Passed tests 2955
Skipped tests: 337
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[melinath]

Looking over this more closely, I'm not sure I fully understand what the "bad case" that we're trying to prevent is. Left some comments below. Let me know what you think!

Additionally, please update https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown to specify the correct update path for people who had been using enable_binary_authorization in 4.X.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 25 deletions(-))
Terraform Beta: Diff ( 1 file changed, 20 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 21 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3300
Passed tests 2964
Skipped tests: 336
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[melinath]

minor docs tweak

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 9 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 2 files changed, 9 insertions(+), 21 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3300
Passed tests 2964
Skipped tests: 336
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[melinath]

LGTM. FWIW I am not able to reproduce the original case that spawned this ticket - the update seems to happen as expected on the main branch (1 single update request) and completes very quickly.

I'm using a different version of Terraform so it's possible that the behavior was changed over time.

All that said, even if the upgrade took two updates, that isn't the main issue. The main issue is correcting the upgrade docs, which this PR does. Eliminating the stray remaining reference to enable_binary_authorization is also good whether or not it's currently causing problems.