add optional input ParentService to BootstrapSharedServiceNetworkingC…

[shuyama1]

…onnection

This will unblock the test in #9513

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 20 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 1 file changed, 20 insertions(+), 11 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 20 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 1 file changed, 20 insertions(+), 11 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3268
Passed tests 2933
Skipped tests: 334
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[rileykarson]

We should use different types per function! That'll stop us from accidentally using bad options, like AddressWithPrefixLength with BootstrapSharedServiceNetworkingConnection

[shuyama1]

But we do need AddressWithPrefixLength with BootstrapSharedServiceNetworkingConnection for some cases, like https://github.com/GoogleCloudPlatform/magic-modules/blob/a007c7ce0f9498648bb61de3e9151b0639ed181b/mmv1/products/looker/Instance.yaml#L74C67-L74C67. That's why I have them combined in one.

[rileykarson]

I think that's a coincidental overlap so far- merging these ones now will encourage merging all future examples too even if there isn't any overlap. With a settings object per bootstrap fn we'd define:

type AddressSettings struct {
	PrefixLength  int
}

type ServiceNetworkSettings struct {
	PrefixLength  int
	ParentService string
}

[shuyama1]

oh, yeah, that makes sense. I'll update it! Thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 34 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 34 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3275
Passed tests 2941
Skipped tests: 334
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log