Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom flattener for diagflowcx agent git integration settings field #9597

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Dec 7, 2023

Behavior of this field seems to have changed since #9078 was merged.

fixes hashicorp/terraform-provider-google#16434

Release Note Template for Downstream PRs (will be copied)

dialogflowcx: fixed a permadiff in the `git_integration_settings` field of `google_diagflow_cx_agent`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3268
Passed tests 2934
Skipped tests: 334
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 7 insertions(+), 30 deletions(-))
Terraform Beta: Diff ( 1 file changed, 7 insertions(+), 30 deletions(-))

@trodge trodge changed the title Add default_from_api to gitIntegrationSettings Add custom flattener for diagflowcx agent git integration settings field Dec 11, 2023
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3290
Passed tests 2952
Skipped tests: 337
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@trodge trodge marked this pull request as ready for review December 12, 2023 00:24
@trodge
Copy link
Contributor Author

trodge commented Dec 12, 2023

The test passes locally. I'm not sure why it doesn't fail in VCR replaying mode.

Copy link
Contributor

@mmurakowski-verily mmurakowski-verily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. My lesson from this is "don't do automation for a thing that's new" :(

@trodge trodge requested a review from melinath December 12, 2023 15:52
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweak to suggest to improve readability, otherwise LGTM & makes sense. I think VCR is probably still using the previous API response, so it still hasn't detected that this is broken. Attn @shuyama1 in terms of thinking about how we might be able to catch and/or re-record cases like this.

…_integration_settings_github_settings.go.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 7 insertions(+), 29 deletions(-))
Terraform Beta: Diff ( 1 file changed, 7 insertions(+), 29 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3292
Passed tests 2955
Skipped tests: 337
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@trodge trodge requested a review from melinath December 14, 2023 00:58
@trodge trodge merged commit 0c03a04 into GoogleCloudPlatform:main Dec 14, 2023
12 checks passed
@trodge trodge deleted the diagflow-cx-agent branch December 20, 2023 18:42
kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
…eld (GoogleCloudPlatform#9597)

* Add a custom flattener for the parent field

* Update mmv1/templates/terraform/custom_flatten/dialogflowcx_agent_git_integration_settings_github_settings.go.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

---------

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
…eld (GoogleCloudPlatform#9597)

* Add a custom flattener for the parent field

* Update mmv1/templates/terraform/custom_flatten/dialogflowcx_agent_git_integration_settings_github_settings.go.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

---------

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccDialogflowCXAgent_update
4 participants