-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom flattener for diagflowcx agent git integration settings field #9597
Conversation
Tests analyticsTotal tests:
|
fd0a1e4
to
7b64da9
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 7 insertions(+), 30 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountJwt |
Rerun these tests in REPLAYING mode to catch issues
|
The test passes locally. I'm not sure why it doesn't fail in VCR replaying mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing. My lesson from this is "don't do automation for a thing that's new" :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small tweak to suggest to improve readability, otherwise LGTM & makes sense. I think VCR is probably still using the previous API response, so it still hasn't detected that this is broken. Attn @shuyama1 in terms of thinking about how we might be able to catch and/or re-record cases like this.
.../terraform/custom_flatten/dialogflowcx_agent_git_integration_settings_github_settings.go.erb
Outdated
Show resolved
Hide resolved
…_integration_settings_github_settings.go.erb Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 7 insertions(+), 29 deletions(-)) |
Tests analyticsTotal tests:
|
…eld (GoogleCloudPlatform#9597) * Add a custom flattener for the parent field * Update mmv1/templates/terraform/custom_flatten/dialogflowcx_agent_git_integration_settings_github_settings.go.erb Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…eld (GoogleCloudPlatform#9597) * Add a custom flattener for the parent field * Update mmv1/templates/terraform/custom_flatten/dialogflowcx_agent_git_integration_settings_github_settings.go.erb Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Behavior of this field seems to have changed since #9078 was merged.
fixes hashicorp/terraform-provider-google#16434
Release Note Template for Downstream PRs (will be copied)