Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netapp active dirtectory #9546
Netapp active dirtectory #9546
Changes from 5 commits
9429d76
942244c
cfd0b2d
57dce25
c16ef7e
a7c0eb6
c6c6c92
27379e7
a57dcd7
af5d5c2
3bca5c5
c463607
de4ffda
8f9af0e
5f971ee
56b1c9e
3a2d879
0bb21fa
60ed6cc
ca62940
8b2943b
b8fdc46
77a174d
2b9f8f5
bc8426d
e7c5027
bb0654f
ab76eba
4a0096e
2b38d87
95d9203
166b8e2
3fd6435
8034e16
0b750f4
b526636
46415d8
b6ebe78
0c1c6a0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this parameter "name" like with any other Google resource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this is good for. "name" is the resourceID of this resource, as suggested above. IMHO this parameter here needs to get deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acording to APi definiton, backOperators is an list of strings and not a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the error I got due to the misconfiguration when sending only a string:
│ Error: Error reading activeDirectory: backup_operators: '' expected type 'string', got unconvertible type '[]interface {}', value: '[bob1]' │ │ with google_netapp_active_directory.my-ad, │ on main.tf line 17, in resource "google_netapp_active_directory" "my-ad": │ 17: resource "google_netapp_active_directory" "my-ad" {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acording to APi definiton, securityOperators is an list of strings and not a string.