Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tf-test- prefix to gkehub2 tests #9524

Merged

Conversation

rileykarson
Copy link
Member

Filled up quota in the VCR project

Release Note Template for Downstream PRs (will be copied)

@rileykarson rileykarson requested review from a team and hao-nan-li and removed request for a team November 27, 2023 19:02
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 16 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 8 files changed, 17 insertions(+), 17 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@rileykarson rileykarson requested review from trodge and removed request for hao-nan-li November 27, 2023 19:35
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3237
Passed tests 2897
Skipped tests: 331
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccGKEHubMembership_gkehubMembershipRegionalExample|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccGKEHubMembershipIamBindingGenerated|TestAccGKEHubMembershipIamMemberGenerated|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccGKEHubMembershipIamPolicyGenerated|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEHubMembership_gkehubMembershipRegionalExample[Debug log]
TestAccGKEHubMembership_gkehubMembershipIssuerExample[Debug log]
TestAccGKEHubMembershipIamBindingGenerated[Debug log]
TestAccGKEHubMembershipIamMemberGenerated[Debug log]
TestAccGKEHubMembership_gkehubMembershipBasicExample[Debug log]
TestAccGKEHubMembershipIamPolicyGenerated[Debug log]
TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample[Debug log]
TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample[Debug log]
TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@rileykarson rileykarson requested a review from a team as a code owner February 14, 2024 18:56
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 10
Skipped tests: 10
Affected tests: 3

Click here to see the affected service packages
  • gkehub2

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample|TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample[Debug log]
TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update[Debug log]
TestAccGKEHub2MembershipBinding_gkehubMembershipBindingBasicExample_update[Debug log]
TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@rileykarson rileykarson merged commit eba7c66 into GoogleCloudPlatform:main Feb 14, 2024
10 of 11 checks passed
@rileykarson rileykarson deleted the gke-cluster-prefix branch February 14, 2024 19:39
tdbhacks pushed a commit to tdbhacks/magic-modules that referenced this pull request Feb 23, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants