Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertexai): Support google_vertex_ai_feature_group #9520

Merged
merged 6 commits into from
Dec 19, 2023

Conversation

shotarok
Copy link
Contributor

@shotarok shotarok commented Nov 25, 2023

A part of hashicorp/terraform-provider-google#16516

Release Note Template for Downstream PRs (will be copied)

`google_vertexai_feature_group`

@shotarok shotarok changed the title feat(vertexai): Support vertex_ai_feature_group feat(vertexai): Support google_vertex_ai_feature_group Nov 25, 2023
@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 25, 2023
@shotarok
Copy link
Contributor Author

@NickElliot Hello 👋 Could you approve the cloud build jobs to run acceptance tests?

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 28, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1310 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1310 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 155 insertions(+))
TF OiCS: Diff ( 4 files changed, 149 insertions(+))

@NickElliot
Copy link
Contributor

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Nov 29, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1310 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1310 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 155 insertions(+))
TF OiCS: Diff ( 4 files changed, 149 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3244
Passed tests 2911
Skipped tests: 331
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccVertexAIFeatureGroup_updated|TestAccVertexAIFeatureGroup_vertexAiFeatureGroupExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIFeatureGroup_updated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVertexAIFeatureGroup_vertexAiFeatureGroupExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@shotarok
Copy link
Contributor Author

Because TestAccVertexAIFeatureGroup_vertexAiFeatureGroupExample should be a subset of TestAccVertexAIFeatureGroup_updated, I'm wondering why the only generated test failed. Could you tell me the error message? Or could you rerun the CI job?

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! The tests are having issues due to a resource name conflict -- this is because both tests are using the static "sample_feature_group_movie_reviews" name. Could you update the generated sample to use a templated value for this name, the instructions located here should show how to do that. Also ideally the tests should be as generic as possible -- can replace the name with something like "example_name" for the name field and "example_id" for the column label.

Thanks for the contributions!

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 12, 2023
@shotarok
Copy link
Contributor Author

@NickElliot Hello 👋 Thank you for your feedback! I've updated the code based on your comments. If the updated code looks good, could you approve the Cloud Builder Job to run acceptance tests? Thanks

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 12, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 1290 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1290 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 155 insertions(+))
TF OiCS: Diff ( 4 files changed, 144 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3294
Passed tests 2954
Skipped tests: 338
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccVertexAIFeatureGroup_vertexAiFeatureGroupExample|TestAccVertexAIFeatureGroup_updated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIFeatureGroup_vertexAiFeatureGroupExample[Debug log]
TestAccVertexAIFeatureGroup_updated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last couple changes! Thanks for contributing

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 14, 2023
shotarok

This comment was marked as resolved.

@shotarok
Copy link
Contributor Author

shotarok commented Dec 14, 2023

@NickElliot Thank you for your reviews! I've applied your suggestions. Could you reapprove the cloud build jobs? Thanks!

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 15, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1295 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 1290 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 155 insertions(+))
TF OiCS: Diff ( 4 files changed, 144 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3298
Passed tests 2961
Skipped tests: 337
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@shotarok
Copy link
Contributor Author

@NickElliot Hello, please let me know if there are additional action items. Thanks!

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants