-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vertexai): Support google_vertex_ai_feature_group #9520
feat(vertexai): Support google_vertex_ai_feature_group #9520
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@NickElliot Hello 👋 Could you approve the cloud build jobs to run acceptance tests? |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1310 insertions(+), 2 deletions(-)) |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1310 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIFeatureGroup_updated|TestAccVertexAIFeatureGroup_vertexAiFeatureGroupExample |
Rerun these tests in REPLAYING mode to catch issues
|
Because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! The tests are having issues due to a resource name conflict -- this is because both tests are using the static "sample_feature_group_movie_reviews" name. Could you update the generated sample to use a templated value for this name, the instructions located here should show how to do that. Also ideally the tests should be as generic as possible -- can replace the name with something like "example_name" for the name field and "example_id" for the column label.
Thanks for the contributions!
mmv1/templates/terraform/examples/vertex_ai_feature_group.tf.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_feature_group_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_feature_group_test.go
Outdated
Show resolved
Hide resolved
@NickElliot Hello 👋 Thank you for your feedback! I've updated the code based on your comments. If the updated code looks good, could you approve the Cloud Builder Job to run acceptance tests? Thanks |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 1290 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIFeatureGroup_vertexAiFeatureGroupExample|TestAccVertexAIFeatureGroup_updated |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last couple changes! Thanks for contributing
mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_feature_group_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_feature_group_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
@NickElliot Thank you for your reviews! I've applied your suggestions. Could you reapprove the cloud build jobs? Thanks! |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 7 files changed, 1295 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests:
|
@NickElliot Hello, please let me know if there are additional action items. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution
A part of hashicorp/terraform-provider-google#16516
Release Note Template for Downstream PRs (will be copied)