Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert project service data source to pre-5.0.0 #9464

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Nov 13, 2023

fixes hashicorp/terraform-provider-google#16515

This makes this particular data source an exception to the strategy outlined in hashicorp/terraform-provider-google#12873.

Release Note Template for Downstream PRs (will be copied)

resourcemanager: made `data_source_google_project_service` no longer return an error when service is not enabled

@trodge trodge requested a review from NickElliot November 13, 2023 21:16
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 9 deletions(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3225
Passed tests 2896
Skipped tests: 329
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@trodge trodge merged commit 721f059 into GoogleCloudPlatform:main Nov 13, 2023
13 checks passed
swamitagupta pushed a commit to swamitagupta/magic-modules that referenced this pull request Nov 14, 2023
davcen pushed a commit to davcen/gcp-magic-modules that referenced this pull request Nov 17, 2023
trodge added a commit to trodge/magic-modules that referenced this pull request Nov 27, 2023
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 28, 2023
jialei-chen pushed a commit to jialei-chen/magic-modules that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan fails when using google_project_service data source with disabled APIs - API not found
3 participants