-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prevent_destroy metadata configuration. #9383
Add prevent_destroy metadata configuration. #9383
Conversation
Add prevent_destroy metadata configuration for Memorystore Redis and Memorystore Redis Cluster examples. Since these are both database resources, it is best for the customer to supply this metadata configuration to prevent accidental deletion.
Hello! I am a robot. It looks like you are a: @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 41 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstance_redisInstanceFullWithPersistenceConfigExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisCluster_redisClusterHaExample |
|
…redis_cluster_generated_test.go
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 59 insertions(+), 23 deletions(-)) |
@@ -11,6 +11,10 @@ resource "google_redis_cluster" "<%= ctx[:primary_resource_id] %>" { | |||
depends_on = [ | |||
google_network_connectivity_service_connection_policy.default | |||
] | |||
|
|||
lifecycle { | |||
prevent_destroy = <%= ctx[:vars]['prevent_destroy'] == 'true' %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prevent_destroy = <%= ctx[:vars]['prevent_destroy'] == 'true' %> | |
prevent_destroy = <%= ctx[:vars]['prevent_destroy'] %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we just want this! We already have the value recorded in the vars map.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already have the changed pushed. Sorry about that!
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 67 insertions(+), 10 deletions(-)) |
Tests analyticsTotal tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Co-authored-by: Demitri Swan <[email protected]>
Co-authored-by: Demitri Swan <[email protected]>
Add prevent_destroy metadata configuration for Memorystore Redis and Memorystore Redis Cluster examples. Since these are both database resources, it is best for the customer to supply this metadata configuration to prevent accidental deletion.
Release Note Template for Downstream PRs (will be copied)