fixed artifact_registry_repository permadiff in unordered array

mmv1/products/artifactregistry/Repository.yaml

@@ -102,6 +102,7 @@ examples:
       repository_id: 'my-repository'
       description: 'example docker repository with cleanup policies'
 custom_code: !ruby/object:Provider::Terraform::CustomCode
+  constants: templates/terraform/constants/artifact_registry_repository.go.erb
   encoder: templates/terraform/encoders/location_from_region.go.erb
 properties:
   - !ruby/object:Api::Type::String
@@ -221,6 +222,7 @@ properties:
     properties:
       - !ruby/object:Api::Type::Array
         name: 'upstreamPolicies'
+        diff_suppress_func: 'upstreamPoliciesDiffSuppress'
         description: |-
           Policies that configure the upstream artifacts distributed by the Virtual
           Repository. Upstream policies cannot be set on a standard repository.

mmv1/templates/terraform/constants/artifact_registry_repository.go.erb

@@ -0,0 +1,54 @@
+<%# The license inside this block applies to this file
+  # Copyright 2023 Google Inc.
+  # Licensed under the Apache License, Version 2.0 (the "License");
+  # you may not use this file except in compliance with the License.
+  # You may obtain a copy of the License at
+  #
+  #     http://www.apache.org/licenses/LICENSE-2.0
+  #
+  # Unless required by applicable law or agreed to in writing, software
+  # distributed under the License is distributed on an "AS IS" BASIS,
+  # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  # See the License for the specific language governing permissions and
+  # limitations under the License.
+-%>
+func upstreamPoliciesDiffSuppress(k, old, new string, d *schema.ResourceData) bool {
+  log.Printf("%v, %v, %v\n", k, old, new)
+  o, n := d.GetChange("virtual_repository_config.0.upstream_policies")
+  oMap, ok := o.([]any)
+  if !ok {
+    return false
+  }
+  nMap, ok := n.([]any)
+  if !ok {
+    return false
+  }
+  hashFunc := func(val any) string {
+    x := val.(map[string]any)
+    return fmt.Sprintf("[id:%v priority:%v repository:%v]", x["id"], x["priority"], x["repository"])
+  }
+
+  return arrayDiffSuppress(oMap, nMap, hashFunc)
+}
+
+func arrayDiffSuppress(old, new []any, hashFunc func(x any) string) bool {
+  oldMap := map[string]bool{}
+  newMap := map[string]bool{}
+  for _, x := range old {
+    key := hashFunc(x)
+    oldMap[key] = true
+  }
+  for _, y := range new {
+    key := hashFunc(y)
+    newMap[key] = true
+  }
+  if len(oldMap) != len(newMap) {
+    return false
+  }
+  for x := range oldMap {
+    if !newMap[x] {
+      return false
+    }
+  }
+  return true
+}