Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container_cluster.html.markdown #9374

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

dr3s
Copy link
Contributor

@dr3s dr3s commented Oct 27, 2023

The current documentation is incorrect. The GPU sharing and multi-instance config are properties of the accelerator not the driver install

container_cluster: Fixed GPU config docs

The current documentation is incorrect. The GPU sharing and multi-instance config are properties of the accelerator not the driverinstall
@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Oct 27, 2023
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Oct 27, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

@slevenick slevenick merged commit 826490d into GoogleCloudPlatform:main Oct 27, 2023
8 checks passed
jiayimeow pushed a commit to jiayimeow/magic-modules that referenced this pull request Oct 31, 2023
The current documentation is incorrect. The GPU sharing and multi-instance config are properties of the accelerator not the driverinstall
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 28, 2023
The current documentation is incorrect. The GPU sharing and multi-instance config are properties of the accelerator not the driverinstall
jialei-chen pushed a commit to jialei-chen/magic-modules that referenced this pull request Nov 29, 2023
The current documentation is incorrect. The GPU sharing and multi-instance config are properties of the accelerator not the driverinstall
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants