Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted TestAccLoggingBucketConfigProject_locked test case. #9373

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

pengq-google
Copy link
Contributor

Cloud logging disallowed deleting locked buckets. Until this change is reverted, we deleted TestAccLoggingBucketConfigProject_locked test case, due to behavioral change of log buckets in project level for now.

Release Note Template for Downstream PRs (will be copied)

Deleted a broken test.

…havioral change of log buckets in project level.
@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 36 deletions(-))
Terraform Beta: Diff ( 1 file changed, 36 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3173
Passed tests 2850
Skipped tests: 319
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironment_ComposerV2|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsCluster_BetaBasicEnumHandWritten

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComposerEnvironment_UpdateComposerV2[Debug log]
TestAccComposerEnvironment_ComposerV2[Debug log]
TestAccContainerAwsCluster_BetaBasicHandWritten[Debug log]
TestAccContainerAwsCluster_BetaBasicEnumHandWritten[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@trodge trodge self-requested a review November 3, 2023 17:21
@trodge trodge merged commit 34a11f3 into GoogleCloudPlatform:main Nov 3, 2023
7 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 28, 2023
…havioral change of log buckets in project level. (GoogleCloudPlatform#9373)

Will add a comment linking the issue in a follow-up PR
jialei-chen pushed a commit to jialei-chen/magic-modules that referenced this pull request Nov 29, 2023
…havioral change of log buckets in project level. (GoogleCloudPlatform#9373)

Will add a comment linking the issue in a follow-up PR
@pengq-google pengq-google deleted the b01 branch December 9, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants