-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error with missing zonal value for compute attached disk #9371
fix error with missing zonal value for compute attached disk #9371
Conversation
…iff with custom one for attached disk
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 75 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withGatewayApiConfig|TestAccContainerAwsCluster_BasicEnumHandWritten|TestAccContainerAwsCluster_BasicHandWritten |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add a test that fails without this change and passes with it?
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 107 insertions(+), 1 deletion(-)) |
The test will be skipped in CI because the test precheck wants GOOGLE_ZONE and GOOGLE_REGION set -- but it fails while on current provider, succeeds with this PR's built one. |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsCluster_BasicEnumHandWritten|TestAccDataprocClusterIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
What's the error you see when you don't skip the test in VCR? |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 106 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeAttachedDisk_zoneless|TestAccDataprocClusterIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes hashicorp/terraform-provider-google#16265
Release Note Template for Downstream PRs (will be copied)