Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip VCR for tests that create bigtable instance #9369

Merged
merged 1 commit into from
Oct 27, 2023
Merged

skip VCR for tests that create bigtable instance #9369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mmv1/products/bigtable/AppProfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ examples:
deletion_protection: 'false'
ignore_read_extra:
- 'ignore_warnings'
# bigtable instance does not use the shared HTTP client, this test creates an instance
skip_vcr: true
- !ruby/object:Provider::Terraform::Examples
name: 'bigtable_app_profile_singlecluster'
primary_resource_id: 'ap'
Expand All @@ -56,6 +58,8 @@ examples:
deletion_protection: 'false'
ignore_read_extra:
- 'ignore_warnings'
# bigtable instance does not use the shared HTTP client, this test creates an instance
skip_vcr: true
- !ruby/object:Provider::Terraform::Examples
name: 'bigtable_app_profile_multicluster'
primary_resource_id: 'ap'
Expand All @@ -69,6 +73,8 @@ examples:
deletion_protection: 'false'
ignore_read_extra:
- 'ignore_warnings'
# bigtable instance does not use the shared HTTP client, this test creates an instance
skip_vcr: true
custom_code: !ruby/object:Provider::Terraform::CustomCode
encoder: templates/terraform/encoders/bigtable_app_profile.go.erb
extra_schema_entry: templates/terraform/extra_schema_entry/bigtable_app_profile.go.erb
Expand Down
2 changes: 2 additions & 0 deletions mmv1/third_party/terraform/services/bigquery/resource_bigquery_table_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,6 +1057,8 @@ func TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateAllowQuotedNewlines(t
}

func TestAccBigQueryDataTable_bigtable(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
acctest.SkipIfVcr(t)
t.Parallel()

context := map[string]interface{}{
Expand Down
1 change: 1 addition & 0 deletions mmv1/third_party/terraform/services/bigtable/resource_bigtable_gc_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ func TestAccBigtableGCPolicy_multiplePolicies(t *testing.T) {
}

func TestAccBigtableGCPolicy_gcRulesPolicy(t *testing.T) {
// bigtable instance does not use the shared HTTP client, this test creates an instance
acctest.SkipIfVcr(t)
t.Parallel()

Expand Down