Update node pool tests to use bootstrapped network

[shuyama1]

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 376 insertions(+), 186 deletions(-))
Terraform Beta: Diff ( 2 files changed, 451 insertions(+), 237 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3170
Passed tests 2811
Skipped tests: 319
Affected tests: 40

Action taken

Found 40 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerClusterDatasource_zonal|TestAccContainerNodePool_withLoggingVariantUpdates|TestAccContainerNodePool_withoutConfidentialBootDisk|TestAccContainerNodePool_withConfidentialBootDisk|TestAccContainerNodePool_withConfidentialNodes|TestAccContainerNodePool_withHostMaintenancePolicy|TestAccContainerNodePool_fastSocket|TestAccContainerNodePool_threadsPerCore|TestAccContainerNodePool_compactPlacement|TestAccContainerNodePool_gvnic|TestAccContainerNodePool_gcfsConfig|TestAccContainerNodePool_customPlacementPolicy|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_localNvmeSsdBlockConfig|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_concurrent|TestAccContainerNodePool_ephemeralStorageLocalSsdConfig|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_totalSize|TestAccContainerNodePool_resize|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_withSoleTenantConfig|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_version|TestAccContainerNodePool_withTaintsUpdate|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withReservationAffinity|TestAccContainerNodePool_withCgroupMode|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_basic|TestAccContainerClusterDatasource_regional

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerClusterDatasource_zonal[Debug log]
TestAccContainerNodePool_withLoggingVariantUpdates[Debug log]
TestAccContainerNodePool_withoutConfidentialBootDisk[Debug log]
TestAccContainerNodePool_withConfidentialBootDisk[Debug log]
TestAccContainerNodePool_fastSocket[Debug log]
TestAccContainerNodePool_threadsPerCore[Debug log]
TestAccContainerNodePool_compactPlacement[Debug log]
TestAccContainerNodePool_gvnic[Debug log]
TestAccContainerNodePool_gcfsConfig[Debug log]
TestAccContainerNodePool_customPlacementPolicy[Debug log]
TestAccContainerNodePool_ephemeralStorageConfig[Debug log]
TestAccContainerNodePool_localNvmeSsdBlockConfig[Debug log]
TestAccContainerNodePool_EmptyGuestAccelerator[Debug log]
TestAccContainerNodePool_shieldedInstanceConfig[Debug log]
TestAccContainerNodePool_012_ConfigModeAttr[Debug log]
TestAccContainerNodePool_concurrent[Debug log]
TestAccContainerNodePool_ephemeralStorageLocalSsdConfig[Debug log]
TestAccContainerNodePool_regionalClusters[Debug log]
TestAccContainerNodePool_resize[Debug log]
TestAccContainerNodePool_withManagement[Debug log]
TestAccContainerNodePool_regionalAutoscaling[Debug log]
TestAccContainerNodePool_withSoleTenantConfig[Debug log]
TestAccContainerNodePool_withGPU[Debug log]
TestAccContainerNodePool_withNodeConfig[Debug log]
TestAccContainerNodePool_version[Debug log]
TestAccContainerNodePool_withTaintsUpdate[Debug log]
TestAccContainerNodePool_withSandboxConfig[Debug log]
TestAccContainerNodePool_withReservationAffinity[Debug log]
TestAccContainerNodePool_withCgroupMode[Debug log]
TestAccContainerNodePool_withWorkloadIdentityConfig[Debug log]
TestAccContainerNodePool_withLinuxNodeConfig[Debug log]
TestAccContainerNodePool_basicWithClusterId[Debug log]
TestAccContainerNodePool_basic[Debug log]
TestAccContainerClusterDatasource_regional[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withConfidentialNodes[Error message] [Debug log]
TestAccContainerNodePool_withHostMaintenancePolicy[Error message] [Debug log]
TestAccContainerNodePool_withNodeConfigScopeAlias[Error message] [Debug log]
TestAccContainerNodePool_autoscaling[Error message] [Debug log]
TestAccContainerNodePool_totalSize[Error message] [Debug log]
TestAccContainerNodePool_withReservationAffinitySpecific[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[shuyama1]

Our network is located in us-central1 while TestAccContainerNodePool_withConfidentialNodes and TestAccContainerNodePool_withHostMaintenancePolicy set locations to others. I went through the original PRs and didn't see particular reasons that we couldn't create them in us-central1. So I just modified them.

Some other tests failed with max secondary ranges reached issue, a rerun should make them work.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 382 insertions(+), 192 deletions(-))
Terraform Beta: Diff ( 2 files changed, 459 insertions(+), 245 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3172
Passed tests 2846
Skipped tests: 319
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withHostMaintenancePolicy|TestAccContainerNodePool_withConfidentialNodes|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_totalSize|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_withReservationAffinitySpecific|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

[shuyama1]

Running VCR skipped tests on TC: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleBeta_MmUpstreamTesting_GOOGLEBETA_PACKAGE_CONTAINER/47970?hideTestsFromDependencies=false&hideProblemsFromDependencies=false

Update: all tests passed on TC

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_withConfidentialNodes[Debug log]
TestAccContainerNodePool_autoscaling[Debug log]
TestAccContainerNodePool_totalSize[Debug log]
TestAccContainerNodePool_withNodeConfigScopeAlias[Debug log]
TestAccContainerNodePool_withReservationAffinitySpecific[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withHostMaintenancePolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[shuyama1]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 382 insertions(+), 192 deletions(-))
Terraform Beta: Diff ( 2 files changed, 459 insertions(+), 245 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3173
Passed tests 2853
Skipped tests: 319
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withHostMaintenancePolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withHostMaintenancePolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[shuyama1]

I can get TestAccContainerNodePool_withHostMaintenancePolicy passed locally but not in VCR project. I'll revert the change in that test for now and will look into the issue and add the bootstrapped network to it in a later PR

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 382 insertions(+), 192 deletions(-))
Terraform Beta: Diff ( 2 files changed, 448 insertions(+), 238 deletions(-))

[rileykarson]

LGTM- I haven't verified all the argument positions within the config or anything, but scanned through and no surprises + all the ones I did check were correct.

[modular-magician]

Tests analytics

Total tests: 3174
Passed tests 2854
Skipped tests: 319
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test