-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workflows): add user_env_vars field + tests #9342
feat(workflows): add user_env_vars field + tests #9342
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 61 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDefaultUniverseDomainDisk|TestAccWorkflowsWorkflow_workflowBetaExample|TestAccWorkflowsWorkflowBeta_update |
Rerun these tests in REPLAYING mode to catch issues
|
Hi @slevenick - all tests have passed. Would it be possible to get a review on this? |
This PR:
google_workflows_workflow
to adduser_env_vars
field which is currently in preview. This allows users to set custom environment variables for WorkflowsNote that since
user_env_vars
is in preview (see here), this new field will only be present in the beta providerFixes: hashicorp/terraform-provider-google#16341
Fixes: hashicorp/terraform-provider-google#15912
Release Note Template for Downstream PRs (will be copied)