Add connection resource of Integration Connectors. #9328

balanaguharsha · 2023-10-23T09:32:50Z

Adding support for Connection resource of Integration connectors.

Release Note Template for Downstream PRs (will be copied)

`google_integration_connectors_connection`

Fixes: hashicorp/terraform-provider-google#16332

modular-magician · 2023-10-23T09:34:38Z

Hello! I am a robot. It looks like you are a: ~~Community Contributor~~ Googler ~~Core Contributor~~. Tests will run automatically.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-10-23T10:01:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 7450 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 12 files changed, 7445 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 2424 insertions(+))
TF OiCS: Diff ( 4 files changed, 118 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_integration_connectors_connection (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_integration_connectors_connection" "primary" {
  auth_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    auth_key  = # value needed
    auth_type = # value needed
    oauth2_auth_code_flow {
      auth_code = # value needed
      auth_uri  = # value needed
      client_id = # value needed
      client_secret {
        secret_version = # value needed
      }
      enable_pkce   = # value needed
      pkce_verifier = # value needed
      redirect_uri  = # value needed
      scopes        = # value needed
    }
    oauth2_client_credentials {
      client_id = # value needed
      client_secret {
        secret_version = # value needed
      }
    }
    oauth2_jwt_bearer {
      client_key {
        secret_version = # value needed
      }
      jwt_claims {
        audience = # value needed
        issuer   = # value needed
        subject  = # value needed
      }
    }
    ssh_public_key {
      cert_type = # value needed
      ssh_client_cert {
        secret_version = # value needed
      }
      ssh_client_cert_pass {
        secret_version = # value needed
      }
      username = # value needed
    }
    user_password {
      password {
        secret_version = # value needed
      }
      username = # value needed
    }
  }
  config_variable {
    boolean_value = # value needed
    encryption_key_value {
      kms_key_name = # value needed
      type         = # value needed
    }
    integer_value = # value needed
    key           = # value needed
    secret_value {
      secret_version = # value needed
    }
    string_value = # value needed
  }
  connector_version = # value needed
  description       = # value needed
  destination_config {
    destination {
      host               = # value needed
      port               = # value needed
      service_attachment = # value needed
    }
    key = # value needed
  }
  eventing_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    auth_config {
      additional_variable {
        boolean_value = # value needed
        encryption_key_value {
          kms_key_name = # value needed
          type         = # value needed
        }
        integer_value = # value needed
        key           = # value needed
        secret_value {
          secret_version = # value needed
        }
        string_value = # value needed
      }
      auth_key  = # value needed
      auth_type = # value needed
      oauth2_auth_code_flow {
        auth_code = # value needed
        auth_uri  = # value needed
        client_id = # value needed
        client_secret {
          secret_version = # value needed
        }
        enable_pkce   = # value needed
        pkce_verifier = # value needed
        redirect_uri  = # value needed
        scopes        = # value needed
      }
      oauth2_client_credentials {
        client_id = # value needed
        client_secret {
          secret_version = # value needed
        }
      }
      oauth2_jwt_bearer {
        client_key {
          secret_version = # value needed
        }
        jwt_claims {
          audience = # value needed
          issuer   = # value needed
          subject  = # value needed
        }
      }
      ssh_public_key {
        cert_type = # value needed
        ssh_client_cert {
          secret_version = # value needed
        }
        ssh_client_cert_pass {
          secret_version = # value needed
        }
        username = # value needed
      }
      user_password {
        password {
          secret_version = # value needed
        }
        username = # value needed
      }
    }
    encryption_key {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    enrichment_enabled = # value needed
    registration_destination_config {
      destinations {
        host               = # value needed
        port               = # value needed
        service_attachment = # value needed
      }
      key = # value needed
    }
  }
  eventing_enablement_type = # value needed
  labels                   = # value needed
  location                 = # value needed
  lock_config {
    locked = # value needed
    reason = # value needed
  }
  log_config {
    enabled = # value needed
  }
  name = # value needed
  node_config {
    max_node_count = # value needed
    min_node_count = # value needed
  }
  service_account = # value needed
  ssl_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    client_cert_type = # value needed
    client_certificate {
      secret_version = # value needed
    }
    client_private_key {
      secret_version = # value needed
    }
    client_private_key_pass {
      secret_version = # value needed
    }
    private_server_certificate {
      secret_version = # value needed
    }
    server_cert_type = # value needed
    trust_model      = # value needed
    type             = # value needed
    use_ssl          = # value needed
  }
  suspended = # value needed
}

modular-magician · 2023-10-23T11:12:57Z

Tests analytics

Total tests: 3169
Passed tests 2848
Skipped tests: 320
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionBasicExample

Get to know how VCR tests work

modular-magician · 2023-10-23T11:14:08Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-10-23T15:56:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 7566 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 12 files changed, 7566 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 2424 insertions(+))
TF OiCS: Diff ( 8 files changed, 266 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_integration_connectors_connection (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_integration_connectors_connection" "primary" {
  auth_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    auth_key = # value needed
    oauth2_auth_code_flow {
      auth_code = # value needed
      auth_uri  = # value needed
      client_id = # value needed
      client_secret {
        secret_version = # value needed
      }
      enable_pkce   = # value needed
      pkce_verifier = # value needed
      redirect_uri  = # value needed
      scopes        = # value needed
    }
    oauth2_client_credentials {
      client_id = # value needed
      client_secret {
        secret_version = # value needed
      }
    }
    oauth2_jwt_bearer {
      client_key {
        secret_version = # value needed
      }
      jwt_claims {
        audience = # value needed
        issuer   = # value needed
        subject  = # value needed
      }
    }
    ssh_public_key {
      cert_type = # value needed
      ssh_client_cert {
        secret_version = # value needed
      }
      ssh_client_cert_pass {
        secret_version = # value needed
      }
      username = # value needed
    }
  }
  config_variable {
    encryption_key_value {
      kms_key_name = # value needed
      type         = # value needed
    }
    integer_value = # value needed
    secret_value {
      secret_version = # value needed
    }
    string_value = # value needed
  }
  destination_config {
    destination {
      port               = # value needed
      service_attachment = # value needed
    }
  }
  eventing_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    auth_config {
      additional_variable {
        boolean_value = # value needed
        encryption_key_value {
          kms_key_name = # value needed
          type         = # value needed
        }
        integer_value = # value needed
        key           = # value needed
        secret_value {
          secret_version = # value needed
        }
        string_value = # value needed
      }
      auth_key = # value needed
      oauth2_auth_code_flow {
        auth_code = # value needed
        auth_uri  = # value needed
        client_id = # value needed
        client_secret {
          secret_version = # value needed
        }
        enable_pkce   = # value needed
        pkce_verifier = # value needed
        redirect_uri  = # value needed
        scopes        = # value needed
      }
      oauth2_client_credentials {
        client_id = # value needed
        client_secret {
          secret_version = # value needed
        }
      }
      oauth2_jwt_bearer {
        client_key {
          secret_version = # value needed
        }
        jwt_claims {
          audience = # value needed
          issuer   = # value needed
          subject  = # value needed
        }
      }
      ssh_public_key {
        cert_type = # value needed
        ssh_client_cert {
          secret_version = # value needed
        }
        ssh_client_cert_pass {
          secret_version = # value needed
        }
        username = # value needed
      }
    }
    encryption_key {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    registration_destination_config {
      destinations {
        port               = # value needed
        service_attachment = # value needed
      }
    }
  }
  labels = # value needed
  lock_config {
    locked = # value needed
    reason = # value needed
  }
  log_config {
    enabled = # value needed
  }
  node_config {
    max_node_count = # value needed
    min_node_count = # value needed
  }
  ssl_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    client_cert_type = # value needed
    client_certificate {
      secret_version = # value needed
    }
    client_private_key {
      secret_version = # value needed
    }
    client_private_key_pass {
      secret_version = # value needed
    }
    private_server_certificate {
      secret_version = # value needed
    }
    server_cert_type = # value needed
    trust_model      = # value needed
    type             = # value needed
    use_ssl          = # value needed
  }
}

modular-magician · 2023-10-23T17:09:54Z

Tests analytics

Total tests: 3172
Passed tests 2849
Skipped tests: 320
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocClusterIamPolicy|TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionAdvancedExample|TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionBasicExample

Get to know how VCR tests work

modular-magician · 2023-10-23T17:17:04Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionAdvancedExample[Error message] [Debug log]
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

melinath · 2023-10-23T17:30:37Z

Drive-by comment: This product should likely be called connectors to match the API subdomain.

shuyama1 · 2023-10-23T22:49:16Z

Drive-by comment: This product should likely be called connectors to match the API subdomain.

Based on the discussion with @balanaguharsha offline, they're undergoing a rebranding now and integration connectors is the official name they'll go with, as to not be confused with connectors in Datafusion

shuyama1

only went through the first half of the resource and will continue with the rest later.

Please also modify the test as we discussed offline - we'll need to use our testing project instead of other locally created projects by accessing it using the datasource and create any dependency resources in the test itself. Please let me if you have any questions.

I've notice most of the fields are not marked as immutable which means they are updatable? If so, we'll need to add update tests as well. See instructions at https://googlecloudplatform.github.io/magic-modules/develop/test/#add-an-update-test

mmv1/products/integrationconnectors/Connection.yaml

modular-magician · 2023-10-25T16:34:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 7617 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 12 files changed, 7617 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 2424 insertions(+))
TF OiCS: Diff ( 8 files changed, 289 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_integration_connectors_connection (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_integration_connectors_connection" "primary" {
  auth_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    auth_key = # value needed
    oauth2_auth_code_flow {
      auth_code = # value needed
      auth_uri  = # value needed
      client_id = # value needed
      client_secret {
        secret_version = # value needed
      }
      enable_pkce   = # value needed
      pkce_verifier = # value needed
      redirect_uri  = # value needed
      scopes        = # value needed
    }
    oauth2_client_credentials {
      client_id = # value needed
      client_secret {
        secret_version = # value needed
      }
    }
    oauth2_jwt_bearer {
      client_key {
        secret_version = # value needed
      }
      jwt_claims {
        audience = # value needed
        issuer   = # value needed
        subject  = # value needed
      }
    }
    ssh_public_key {
      cert_type = # value needed
      ssh_client_cert {
        secret_version = # value needed
      }
      ssh_client_cert_pass {
        secret_version = # value needed
      }
      username = # value needed
    }
  }
  config_variable {
    encryption_key_value {
      kms_key_name = # value needed
      type         = # value needed
    }
    secret_value {
      secret_version = # value needed
    }
  }
  destination_config {
    destination {
      port               = # value needed
      service_attachment = # value needed
    }
  }
  eventing_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    auth_config {
      additional_variable {
        boolean_value = # value needed
        encryption_key_value {
          kms_key_name = # value needed
          type         = # value needed
        }
        integer_value = # value needed
        key           = # value needed
        secret_value {
          secret_version = # value needed
        }
        string_value = # value needed
      }
      auth_key = # value needed
      oauth2_auth_code_flow {
        auth_code = # value needed
        auth_uri  = # value needed
        client_id = # value needed
        client_secret {
          secret_version = # value needed
        }
        enable_pkce   = # value needed
        pkce_verifier = # value needed
        redirect_uri  = # value needed
        scopes        = # value needed
      }
      oauth2_client_credentials {
        client_id = # value needed
        client_secret {
          secret_version = # value needed
        }
      }
      oauth2_jwt_bearer {
        client_key {
          secret_version = # value needed
        }
        jwt_claims {
          audience = # value needed
          issuer   = # value needed
          subject  = # value needed
        }
      }
      ssh_public_key {
        cert_type = # value needed
        ssh_client_cert {
          secret_version = # value needed
        }
        ssh_client_cert_pass {
          secret_version = # value needed
        }
        username = # value needed
      }
    }
    encryption_key {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    registration_destination_config {
      destinations {
        port               = # value needed
        service_attachment = # value needed
      }
    }
  }
  labels   = # value needed
  location = # value needed
  lock_config {
    locked = # value needed
    reason = # value needed
  }
  log_config {
    enabled = # value needed
  }
  node_config {
    max_node_count = # value needed
    min_node_count = # value needed
  }
  ssl_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    client_cert_type = # value needed
    client_certificate {
      secret_version = # value needed
    }
    client_private_key {
      secret_version = # value needed
    }
    client_private_key_pass {
      secret_version = # value needed
    }
    private_server_certificate {
      secret_version = # value needed
    }
    server_cert_type = # value needed
    trust_model      = # value needed
    type             = # value needed
    use_ssl          = # value needed
  }
}

modular-magician · 2023-10-25T17:17:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 7617 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 12 files changed, 7617 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 2424 insertions(+))
TF OiCS: Diff ( 8 files changed, 289 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_integration_connectors_connection (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_integration_connectors_connection" "primary" {
  auth_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    auth_key = # value needed
    oauth2_auth_code_flow {
      auth_code = # value needed
      auth_uri  = # value needed
      client_id = # value needed
      client_secret {
        secret_version = # value needed
      }
      enable_pkce   = # value needed
      pkce_verifier = # value needed
      redirect_uri  = # value needed
      scopes        = # value needed
    }
    oauth2_client_credentials {
      client_id = # value needed
      client_secret {
        secret_version = # value needed
      }
    }
    oauth2_jwt_bearer {
      client_key {
        secret_version = # value needed
      }
      jwt_claims {
        audience = # value needed
        issuer   = # value needed
        subject  = # value needed
      }
    }
    ssh_public_key {
      cert_type = # value needed
      ssh_client_cert {
        secret_version = # value needed
      }
      ssh_client_cert_pass {
        secret_version = # value needed
      }
      username = # value needed
    }
  }
  config_variable {
    encryption_key_value {
      kms_key_name = # value needed
      type         = # value needed
    }
    secret_value {
      secret_version = # value needed
    }
  }
  destination_config {
    destination {
      port               = # value needed
      service_attachment = # value needed
    }
  }
  eventing_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    auth_config {
      additional_variable {
        boolean_value = # value needed
        encryption_key_value {
          kms_key_name = # value needed
          type         = # value needed
        }
        integer_value = # value needed
        key           = # value needed
        secret_value {
          secret_version = # value needed
        }
        string_value = # value needed
      }
      auth_key = # value needed
      oauth2_auth_code_flow {
        auth_code = # value needed
        auth_uri  = # value needed
        client_id = # value needed
        client_secret {
          secret_version = # value needed
        }
        enable_pkce   = # value needed
        pkce_verifier = # value needed
        redirect_uri  = # value needed
        scopes        = # value needed
      }
      oauth2_client_credentials {
        client_id = # value needed
        client_secret {
          secret_version = # value needed
        }
      }
      oauth2_jwt_bearer {
        client_key {
          secret_version = # value needed
        }
        jwt_claims {
          audience = # value needed
          issuer   = # value needed
          subject  = # value needed
        }
      }
      ssh_public_key {
        cert_type = # value needed
        ssh_client_cert {
          secret_version = # value needed
        }
        ssh_client_cert_pass {
          secret_version = # value needed
        }
        username = # value needed
      }
    }
    encryption_key {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    registration_destination_config {
      destinations {
        port               = # value needed
        service_attachment = # value needed
      }
    }
  }
  labels   = # value needed
  location = # value needed
  lock_config {
    locked = # value needed
    reason = # value needed
  }
  log_config {
    enabled = # value needed
  }
  node_config {
    max_node_count = # value needed
    min_node_count = # value needed
  }
  ssl_config {
    additional_variable {
      boolean_value = # value needed
      encryption_key_value {
        kms_key_name = # value needed
        type         = # value needed
      }
      integer_value = # value needed
      key           = # value needed
      secret_value {
        secret_version = # value needed
      }
      string_value = # value needed
    }
    client_cert_type = # value needed
    client_certificate {
      secret_version = # value needed
    }
    client_private_key {
      secret_version = # value needed
    }
    client_private_key_pass {
      secret_version = # value needed
    }
    private_server_certificate {
      secret_version = # value needed
    }
    server_cert_type = # value needed
    trust_model      = # value needed
    type             = # value needed
    use_ssl          = # value needed
  }
}

modular-magician · 2023-10-25T18:28:49Z

Tests analytics

Total tests: 3174
Passed tests 2852
Skipped tests: 319
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocClusterIamPolicy|TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionAdvancedExample|TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionBasicExample

Get to know how VCR tests work

modular-magician · 2023-10-25T18:35:26Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionAdvancedExample[Error message] [Debug log]
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

shuyama1

Went through the resource and left some comments.

mmv1/products/integrationconnectors/product.yaml

mmv1/products/integrationconnectors/Connection.yaml

modular-magician · 2023-11-05T12:32:07Z

Tests analytics

Total tests: 3211
Passed tests 2880
Skipped tests: 323
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionBasicExample|TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionOauthCcExample|TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionAdvancedExample|TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionOauthSshExample|TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionOauthJwtExample|TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionSaExample|TestAccIntegrationConnectorsConnection_update|TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionOauthExample

Get to know how VCR tests work

modular-magician · 2023-11-05T13:02:18Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionBasicExample[Debug log]
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionOauthCcExample[Debug log]
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionAdvancedExample[Debug log]
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionOauthSshExample[Debug log]
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionOauthJwtExample[Debug log]
TestAccIntegrationConnectorsConnection_update[Debug log]
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionOauthExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionSaExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-11-05T13:25:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 8197 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 8197 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 1869 insertions(+))
TF OiCS: Diff ( 28 files changed, 1441 insertions(+))

modular-magician · 2023-11-05T14:37:18Z

Tests analytics

Total tests: 3211
Passed tests 2886
Skipped tests: 323
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionSaExample|TestAccDataSourceGoogleServiceAccountAccessToken_basic

Get to know how VCR tests work

modular-magician · 2023-11-05T14:50:35Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionSaExample[Debug log]
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

modular-magician · 2023-11-06T07:53:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 8197 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 8197 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 1869 insertions(+))
TF OiCS: Diff ( 28 files changed, 1441 insertions(+))

modular-magician · 2023-11-06T09:05:18Z

Tests analytics

Total tests: 3211
Passed tests 2887
Skipped tests: 323
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocJobIamPolicy

Get to know how VCR tests work

modular-magician · 2023-11-06T09:11:55Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

shuyama1 · 2023-11-07T00:54:54Z

/gcbrun

modular-magician · 2023-11-07T01:05:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 8197 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 8197 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 1869 insertions(+))
TF OiCS: Diff ( 28 files changed, 1441 insertions(+))

modular-magician · 2023-11-07T02:18:03Z

Tests analytics

Total tests: 3214
Passed tests 2888
Skipped tests: 325
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionAdvancedExample

Get to know how VCR tests work

modular-magician · 2023-11-07T02:29:49Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIntegrationConnectorsConnection_integrationConnectorsConnectionAdvancedExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

mmv1/templates/terraform/constants/integration_connectors_connection.go.erb

modular-magician · 2023-11-07T18:29:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 7662 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 7662 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 1869 insertions(+))
TF OiCS: Diff ( 28 files changed, 1441 insertions(+))

modular-magician · 2023-11-07T19:41:57Z

Tests analytics

Total tests: 3216
Passed tests 2891
Skipped tests: 325
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

shuyama1

Thank you!

…rm#9328)

Add connection resource of Integration Connectors.

6a1113d

modular-magician requested a review from shuyama1 October 23, 2023 09:34

balanaguharsha added 2 commits October 23, 2023 09:41

Removing trailing whitespace

65e7e63

Removing trailing whitespace

6a43223

balanaguharsha added 2 commits October 23, 2023 15:41

Removing trailing whitespace

aa3d879

Add zendesk example for connection example.

029ff94

shuyama1 reviewed Oct 23, 2023

View reviewed changes

Add zendesk example for connection example.

68fd017

modular-magician requested a review from shuyama1 October 25, 2023 14:38

balanaguharsha added 4 commits October 25, 2023 14:45

Removing trailing whitespaces

46c3725

Removing trailing whitespaces

d7282ed

Removing trailing whitespaces

f961559

Removing trailing whitespaces

0e44cb5

Removing trailing whitespaces

2657ed1

shuyama1 requested changes Oct 27, 2023

View reviewed changes

Merge branch 'GoogleCloudPlatform:main' into main

90393e7

modular-magician requested a review from shuyama1 October 30, 2023 15:32

balanaguharsha force-pushed the main branch from 402fab4 to 1d228c7 Compare November 5, 2023 13:14

balanaguharsha force-pushed the main branch from 1d228c7 to eed3b77 Compare November 6, 2023 07:42

shuyama1 reviewed Nov 7, 2023

View reviewed changes

mmv1/templates/terraform/constants/integration_connectors_connection.go.erb Show resolved Hide resolved

Merge branch 'GoogleCloudPlatform:main' into main

7481842

balanaguharsha force-pushed the main branch from eed3b77 to 7481842 Compare November 7, 2023 18:18

modular-magician requested a review from shuyama1 November 7, 2023 18:19

shuyama1 approved these changes Nov 7, 2023

View reviewed changes

shuyama1 merged commit f6c39ca into GoogleCloudPlatform:main Nov 7, 2023
6 checks passed

rileykarson mentioned this pull request Nov 13, 2023

Add Support for Integration Connectors hashicorp/terraform-provider-google#15192

Closed

swamitagupta pushed a commit to swamitagupta/magic-modules that referenced this pull request Nov 14, 2023

Add connection resource of Integration Connectors. (GoogleCloudPlatfo…

a0e5025

…rm#9328)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 28, 2023

Add connection resource of Integration Connectors. (GoogleCloudPlatfo…

6f3a8c6

…rm#9328)

jialei-chen pushed a commit to jialei-chen/magic-modules that referenced this pull request Nov 29, 2023

Add connection resource of Integration Connectors. (GoogleCloudPlatfo…

ba01628

…rm#9328)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add connection resource of Integration Connectors. #9328

Add connection resource of Integration Connectors. #9328

balanaguharsha commented Oct 23, 2023 •

edited by shuyama1

Loading

modular-magician commented Oct 23, 2023

modular-magician commented Oct 23, 2023

modular-magician commented Oct 23, 2023

modular-magician commented Oct 23, 2023

modular-magician commented Oct 23, 2023

modular-magician commented Oct 23, 2023

modular-magician commented Oct 23, 2023

melinath commented Oct 23, 2023

shuyama1 commented Oct 23, 2023

shuyama1 left a comment

modular-magician commented Oct 25, 2023

modular-magician commented Oct 25, 2023

modular-magician commented Oct 25, 2023

modular-magician commented Oct 25, 2023

shuyama1 left a comment

modular-magician commented Nov 5, 2023

modular-magician commented Nov 5, 2023

modular-magician commented Nov 5, 2023

modular-magician commented Nov 5, 2023

modular-magician commented Nov 5, 2023

modular-magician commented Nov 6, 2023

modular-magician commented Nov 6, 2023

modular-magician commented Nov 6, 2023

shuyama1 commented Nov 7, 2023

modular-magician commented Nov 7, 2023

modular-magician commented Nov 7, 2023

modular-magician commented Nov 7, 2023

modular-magician commented Nov 7, 2023

modular-magician commented Nov 7, 2023

shuyama1 left a comment

Add connection resource of Integration Connectors. #9328

Add connection resource of Integration Connectors. #9328

Conversation

balanaguharsha commented Oct 23, 2023 • edited by shuyama1 Loading

modular-magician commented Oct 23, 2023

modular-magician commented Oct 23, 2023

Diff report

Missing test report

modular-magician commented Oct 23, 2023

Tests analytics

Action taken

modular-magician commented Oct 23, 2023

modular-magician commented Oct 23, 2023

Diff report

Missing test report

modular-magician commented Oct 23, 2023

Tests analytics

Action taken

modular-magician commented Oct 23, 2023

Rerun these tests in REPLAYING mode to catch issues

melinath commented Oct 23, 2023

shuyama1 commented Oct 23, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

modular-magician commented Oct 25, 2023

Diff report

Missing test report

modular-magician commented Oct 25, 2023

Diff report

Missing test report

modular-magician commented Oct 25, 2023

Tests analytics

Action taken

modular-magician commented Oct 25, 2023

Rerun these tests in REPLAYING mode to catch issues

shuyama1 left a comment

Choose a reason for hiding this comment

modular-magician commented Nov 5, 2023

Tests analytics

Action taken

modular-magician commented Nov 5, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Nov 5, 2023

Diff report

modular-magician commented Nov 5, 2023

Tests analytics

Action taken

modular-magician commented Nov 5, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Nov 6, 2023

Diff report

modular-magician commented Nov 6, 2023

Tests analytics

Action taken

modular-magician commented Nov 6, 2023

Rerun these tests in REPLAYING mode to catch issues

shuyama1 commented Nov 7, 2023

modular-magician commented Nov 7, 2023

Diff report

modular-magician commented Nov 7, 2023

Tests analytics

Action taken

modular-magician commented Nov 7, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Nov 7, 2023

Diff report

modular-magician commented Nov 7, 2023

Tests analytics

shuyama1 left a comment

Choose a reason for hiding this comment

balanaguharsha commented Oct 23, 2023 •

edited by shuyama1

Loading