Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix google_iam_deny_policy tests #9321

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix google_iam_deny_policy tests #9321

merged 1 commit into from
Oct 23, 2023

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Oct 20, 2023

fixes hashicorp/terraform-provider-google#11509

The tests failed and returned the error that the caller doesn't have the permission to delete the created project.

The deny policy created in the tests is to prevent the deletion of projects. After the deny policy is deleted, it takes time to propagate in the system. The delay could cause the failure to delete the project.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

@zli82016 zli82016 changed the title Decrease the iam access boundary in tests Fix google_iam_deny_policy tests Oct 20, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3170
Passed tests 2847
Skipped tests: 320
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccIAM2DenyPolicy_iamDenyPolicyUpdate|TestAccIAM2DenyPolicy_iamDenyPolicyBasicExample|TestAccDataSourceGoogleServiceAccountAccessToken_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIAM2DenyPolicy_iamDenyPolicyUpdate[Debug log]
TestAccIAM2DenyPolicy_iamDenyPolicyBasicExample[Debug log]
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@zli82016 zli82016 requested a review from slevenick October 23, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccIAM2DenyPolicy_iamDenyPolicyUpdate
3 participants