feat(spanner): add instance autoscaling attributed to spanner instance resource

[rahul2393]

Release Note Template for Downstream PRs (will be copied)

spanner: added `autoscaling_config` field to  `google_spanner_instance`

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 290 insertions(+))
Terraform Beta: Diff ( 2 files changed, 290 insertions(+))
TF Conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_spanner_instance (34 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_spanner_instance" "primary" {
  autoscaling_config {
    autoscaling_limits {
      max_scaled_in_replicas {
        fixed   = # value needed
        percent = # value needed
      }
      time_window_sec = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3142
Passed tests 2824
Skipped tests: 318
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[ScottSuarez]

Hello, I notice this pr is in draft. Let me know if there is anything I can do to help. As our bot suggests you'll need to add test for these new configurations :)

[rahul2393]

@ScottSuarez PR is ready for review

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 519 insertions(+))
Terraform Beta: Diff ( 2 files changed, 519 insertions(+))
TF Conversion: Diff ( 1 file changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_spanner_instance (34 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_spanner_instance" "primary" {
  autoscaling_config {
    autoscaling_limits {
      max_limit {
        max_nodes            = # value needed
        max_processing_units = # value needed
      }
      min_limit {
        min_nodes            = # value needed
        min_processing_units = # value needed
      }
    }
    autoscaling_targets {
      high_priority_cpu_utilization_percent = # value needed
      storage_utilization_percent           = # value needed
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 521 insertions(+))
Terraform Beta: Diff ( 2 files changed, 521 insertions(+))
TF Conversion: Diff ( 1 file changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_spanner_instance (34 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_spanner_instance" "primary" {
  autoscaling_config {
    autoscaling_limits {
      max_limit {
        max_nodes            = # value needed
        max_processing_units = # value needed
      }
      min_limit {
        min_nodes            = # value needed
        min_processing_units = # value needed
      }
    }
    autoscaling_targets {
      high_priority_cpu_utilization_percent = # value needed
      storage_utilization_percent           = # value needed
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 521 insertions(+))
Terraform Beta: Diff ( 2 files changed, 521 insertions(+))
TF Conversion: Diff ( 1 file changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_spanner_instance (34 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_spanner_instance" "primary" {
  autoscaling_config {
    autoscaling_limits {
      max_limit {
        max_nodes            = # value needed
        max_processing_units = # value needed
      }
      min_limit {
        min_nodes            = # value needed
        min_processing_units = # value needed
      }
    }
    autoscaling_targets {
      high_priority_cpu_utilization_percent = # value needed
      storage_utilization_percent           = # value needed
    }
  }
}

[rahul2393]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 557 insertions(+))
Terraform Beta: Diff ( 3 files changed, 557 insertions(+))
TF Conversion: Diff ( 1 file changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_spanner_instance (35 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_spanner_instance" "primary" {
  autoscaling_config {
    autoscaling_limits {
      max_limit {
        max_processing_units = # value needed
      }
      min_limit {
        min_processing_units = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3173
Passed tests 2851
Skipped tests: 319
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccSpannerInstance_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSpannerInstance_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 557 insertions(+))
Terraform Beta: Diff ( 3 files changed, 557 insertions(+))
TF Conversion: Diff ( 1 file changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_spanner_instance (35 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_spanner_instance" "primary" {
  autoscaling_config {
    autoscaling_limits {
      max_limit {
        max_processing_units = # value needed
      }
      min_limit {
        min_processing_units = # value needed
      }
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 557 insertions(+))
Terraform Beta: Diff ( 3 files changed, 557 insertions(+))
TF Conversion: Diff ( 1 file changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_spanner_instance (35 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_spanner_instance" "primary" {
  autoscaling_config {
    autoscaling_limits {
      max_limit {
        max_processing_units = # value needed
      }
      min_limit {
        min_processing_units = # value needed
      }
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 572 insertions(+))
Terraform Beta: Diff ( 4 files changed, 572 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_spanner_instance (35 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_spanner_instance" "primary" {
  autoscaling_config {
    autoscaling_limits {
      max_limit {
        max_processing_units = # value needed
      }
      min_limit {
        min_processing_units = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3174
Passed tests 2850
Skipped tests: 320
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareDatasetIamPolicy|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccServiceAccountIamPolicy|TestAccSpannerInstanceIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcareDatasetIamPolicy[Debug log]
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]
TestAccServiceAccountIamPolicy[Debug log]
TestAccSpannerInstanceIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 623 insertions(+))
Terraform Beta: Diff ( 3 files changed, 623 insertions(+))
TF Conversion: Diff ( 1 file changed, 160 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3176
Passed tests 2855
Skipped tests: 321
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[ScottSuarez]

nit on description

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 623 insertions(+))
Terraform Beta: Diff ( 3 files changed, 623 insertions(+))
TF Conversion: Diff ( 1 file changed, 160 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3176
Passed tests 2855
Skipped tests: 321
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log