Alloydb crr secondary instance

[199201shubhamsahu]

To Create a Secondary Instance inside a secondary cluster, set the instance_type to point to the cluster_type of the associated secondary cluster & set lifecycle.ignore_changes = [instance_type]
Avoid setting instance_type = "SECONDARY", as promoting a secondary cluster to a primary cluster also modifies the instance_type of the associated secondary instance

  instance_type = google_alloydb_cluster.<secondary_cluster_name>.cluster_type
  lifecycle {
    ignore_changes = [instance_type]
  }

Release Note Template for Downstream PRs (will be copied)

alloydb: added "SECONDARY" as an additional option for `instance_type` field in `google_alloydb_instance` to support creation of secondary instance inside a secondary cluster. 

alloydb: added "deletion_policy" to `google_alloydb_cluster` to allow force-destroying instances along with their cluster. This is necessary to delete secondary instances, which cannot be deleted otherwise.

alloydb: increased default timeout on `google_alloydb_instance` to 120m from 40m

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1408 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1408 insertions(+), 10 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 9 files changed, 327 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3141
Passed tests 2777
Skipped tests: 318
Affected tests: 46

Action taken

Found 46 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_secondaryClusterUsingCMEK|TestAccAlloydbCluster_secondaryClusterAddAutomatedBackupPolicy|TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary|TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary|TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig|TestAccAlloydbCluster_secondaryClusterMandatoryFields|TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbCluster_secondaryClusterWithNetworkConfig|TestAccAlloydbInstance_alloydbSecondaryInstanceBasicExample|TestAccAlloydbCluster_alloydbSecondaryClusterBasicExample|TestAccAlloydbInstance_createInstanceWithMandatoryFields|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight|TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccAlloydbCluster_withNetworkConfig|TestAccAlloydbInstance_createPrimaryAndReadPoolInstance|TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_update|TestAccAlloydbCluster_continuousBackup_noChangeIfRemoved|TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy|TestAccAlloydbUser_updatePassword_BuiltIn|TestAccAlloydbCluster_restore|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_continuousBackup_update|TestAccAlloydbCluster_update|TestAccAlloydbCluster_missingWeeklySchedule|TestAccAlloydbUser_updateRoles_BuiltIn|TestAccAlloydbUser_alloydbUserBuiltinExample|TestAccAlloydbCluster_withNetworkConfigAndAllocatedIPRange|TestAccAlloydbCluster_continuousBackup_enabledByDefault|TestAccAlloydbCluster_alloydbClusterBasicExample|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbUser_alloydbUserIamExample|TestAccAlloydbCluster_continuousBackup_update_noChangeIfDefaultsSet|TestAccAlloydbUser_updateRoles_IAM|TestAccAlloydbInstance_alloydbInstanceBasicExample|TestAccAlloydbCluster_usingCMEK|TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable|TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbBackup_createBackupWithMandatoryFields|TestAccAlloydbBackup_update|TestAccAlloydbCluster_mandatoryFields|TestAccAlloydbCluster_maximumFields

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_secondaryClusterUsingCMEK[Debug log]
TestAccAlloydbCluster_secondaryClusterAddAutomatedBackupPolicy[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButClusterTypeIsPrimary[Debug log]
TestAccAlloydbCluster_secondaryClusterDefinedSecondaryConfigButMissingClusterTypeSecondary[Debug log]
TestAccAlloydbCluster_secondaryClusterMissingSecondaryConfig[Debug log]
TestAccAlloydbCluster_secondaryClusterMandatoryFields[Debug log]
TestAccAlloydbCluster_secondaryClusterWithNetworkConfig[Debug log]
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicExample[Debug log]
TestAccAlloydbCluster_alloydbSecondaryClusterBasicExample[Debug log]
TestAccAlloydbInstance_createInstanceWithMandatoryFields[Debug log]
TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight[Debug log]
TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_alloydbClusterFullExample[Debug log]
TestAccAlloydbCluster_withNetworkConfig[Debug log]
TestAccAlloydbInstance_createPrimaryAndReadPoolInstance[Debug log]
TestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbCluster_continuousBackup_noChangeIfRemoved[Debug log]
TestAccAlloydbCluster_deleteTimeBasedRetentionPolicy[Debug log]
TestAccAlloydbUser_updatePassword_BuiltIn[Debug log]
TestAccAlloydbCluster_restore[Debug log]
TestAccAlloydbBackup_alloydbBackupBasicExample[Debug log]
TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_continuousBackup_update[Debug log]
TestAccAlloydbCluster_update[Debug log]
TestAccAlloydbCluster_missingWeeklySchedule[Debug log]
TestAccAlloydbUser_updateRoles_BuiltIn[Debug log]
TestAccAlloydbUser_alloydbUserBuiltinExample[Debug log]
TestAccAlloydbCluster_withNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbCluster_continuousBackup_enabledByDefault[Debug log]
TestAccAlloydbCluster_alloydbClusterBasicExample[Debug log]
TestAccAlloydbBackup_alloydbBackupFullExample[Debug log]
TestAccAlloydbUser_alloydbUserIamExample[Debug log]
TestAccAlloydbCluster_continuousBackup_update_noChangeIfDefaultsSet[Debug log]
TestAccAlloydbUser_updateRoles_IAM[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicExample[Debug log]
TestAccAlloydbCluster_usingCMEK[Debug log]
TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable[Debug log]
TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable[Debug log]
TestAccAlloydbBackup_usingCMEK[Debug log]
TestAccAlloydbBackup_createBackupWithMandatoryFields[Debug log]
TestAccAlloydbBackup_update[Debug log]
TestAccAlloydbCluster_mandatoryFields[Debug log]
TestAccAlloydbCluster_maximumFields[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1386 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1386 insertions(+), 10 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 8 files changed, 324 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1373 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1373 insertions(+), 10 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))
TF OiCS: Diff ( 8 files changed, 324 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3144
Passed tests 2815
Skipped tests: 318
Affected tests: 11

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_secondaryClusterUpdate|TestAccAlloydbInstance_alloydbSecondaryInstanceBasicExample|TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_continuousBackup_update|TestAccAlloydbCluster_update|TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable|TestAccAlloydbCluster_secondaryClusterAddAutomatedBackupPolicy|TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight|TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable|TestAccAlloydbCluster_restore

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryClusterUpdate[Debug log]
TestAccAlloydbCluster_addAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_continuousBackup_update[Debug log]
TestAccAlloydbCluster_update[Debug log]
TestAccAlloydbCluster_CMEKInAutomatedBackupIsUpdatable[Debug log]
TestAccAlloydbCluster_secondaryClusterAddAutomatedBackupPolicy[Debug log]
TestAccAlloydbCluster_deleteAutomatedBackupPolicyAndInitialUser[Debug log]
TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight[Debug log]
TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable[Debug log]
TestAccAlloydbCluster_restore[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1136 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 4 files changed, 1136 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3141
Passed tests 2825
Skipped tests: 316
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 643 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 6 files changed, 643 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 169 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 643 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 6 files changed, 643 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 169 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3145
Passed tests 2825
Skipped tests: 316
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance|TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_secondaryInstanceUpdate|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 3145
Passed tests 2822
Skipped tests: 316
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance|TestAccAlloydbInstance_secondaryInstanceUpdate|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Debug log]
TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdate[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdate[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 3181
Passed tests 2854
Skipped tests: 319
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_secondaryInstanceMaximumFields|TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig|TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance|TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag|TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig|TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample|TestAccBigQueryDataTable_bigtable

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_secondaryInstanceMaximumFields[Debug log]
TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag[Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig[Debug log]
TestAccAlloydbInstance_alloydbSecondaryInstanceBasicTestExample[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Error message] [Debug log]
TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

See errors inline in the results!

[199201shubhamsahu]

See errors inline in the results!

Fixed TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig still failed due to Quota limit

So moved few of the secondary cluster location to us-west1 in tests

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 865 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 6 files changed, 865 insertions(+), 10 deletions(-))
TF OiCS: Diff ( 4 files changed, 151 insertions(+))

[rileykarson]

As a followup can you confirm that we have no more than 5 clusters in a region other than us-central1 in tests? We bumped out quota there. You can do that after this PR- it'll just stop us from failing to re-record on changes that affect AlloyDB.

Our retries need to be fixed to handle this situation correctly- @roaks3 did we file an issue for that?

[modular-magician]

Tests analytics

Total tests: 3181
Passed tests 2854
Skipped tests: 319
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig|TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange|TestAccAlloydbInstance_secondaryInstanceMaximumFields|TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance|TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironment_ComposerV2|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsCluster_BetaBasicEnumHandWritten

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig[Debug log]
TestAccAlloydbCluster_secondaryInstanceWithNetworkConfigAndAllocatedIPRange[Debug log]
TestAccAlloydbInstance_secondaryInstanceMaximumFields[Debug log]
TestAccAlloydbInstance_secondaryInstanceWithReadPoolInstance[Debug log]
TestAccComposerEnvironment_UpdateComposerV2[Debug log]
TestAccComposerEnvironment_ComposerV2[Debug log]
TestAccContainerAwsCluster_BetaBasicHandWritten[Debug log]
TestAccContainerAwsCluster_BetaBasicEnumHandWritten[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[roaks3]

Our retries need to be fixed to handle this situation correctly- @roaks3 did we file an issue for that?

Yea, apologies for the delay, I was partway through writing it up: hashicorp/terraform-provider-google#16392.

[rileykarson]

Generally LGTM, barring one comment left to resolve inline- I feel reasonably good about this. I don't love the pre_update we're using, but the reasoning behind it was reasonable- when a promotion happens, the instance will be promoted out of band and we don't want to destroy the now-primary instance. This resource doesn't have a deletion_protection field which could be an alternate way to guard for those cases.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 859 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 6 files changed, 859 insertions(+), 10 deletions(-))
TF OiCS: Diff ( 4 files changed, 151 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3184
Passed tests 2857
Skipped tests: 325
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountJwt|TestAccDataSourceGoogleServiceAccountAccessToken_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[rileykarson]

LGTM!

[MoAqsam]

Has this been released yet ? Looking to create a secondary instance in a secondary cluster, however can't find any documentation anywhere.