Storage config

[spapi17]

Release Note Template for Downstream PRs (will be copied)

composer: added `storage_config` to `google_composer_environment`

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 354 insertions(+), 196 deletions(-))
Terraform Beta: Diff ( 3 files changed, 353 insertions(+), 196 deletions(-))

[rileykarson]

I see this is in draft. Let me know when you want me to make a review pass!

[dzarmola]

Yes, this will stay as a draft for a moment, and I'll be picking it up - we're still in the process of actually releasing the API field that this will use. I'll let you know :)

[spapi17]

/gcbrun

[rileykarson]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 353 insertions(+), 196 deletions(-))
Terraform Beta: Diff ( 3 files changed, 353 insertions(+), 196 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 2755 insertions(+), 181 deletions(-))
Terraform Beta: Diff ( 3 files changed, 2900 insertions(+), 193 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 156 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 156 insertions(+), 5 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change Detection Failed

The breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 156 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 156 insertions(+), 5 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 157 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 5 files changed, 157 insertions(+), 11 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 168 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 5 files changed, 168 insertions(+), 9 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3143
Passed tests 2822
Skipped tests: 318
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 158 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 158 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_composer_environment (69 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_composer_environment" "primary" {
  storage_config {
    bucket = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3185
Passed tests 2859
Skipped tests: 325
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComposerEnvironment_customBucket

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComposerEnvironment_customBucket[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 158 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 158 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_composer_environment (69 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_composer_environment" "primary" {
  storage_config {
    bucket = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3185
Passed tests 2860
Skipped tests: 325
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 158 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 158 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_composer_environment (69 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_composer_environment" "primary" {
  storage_config {
    bucket = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3185
Passed tests 2860
Skipped tests: 325
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 158 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 3 files changed, 158 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_composer_environment (69 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_composer_environment" "primary" {
  storage_config {
    bucket = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 3187
Passed tests 2861
Skipped tests: 325
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 149 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 4 files changed, 154 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3198
Passed tests 2873
Skipped tests: 325
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[rileykarson]

LGTM, thanks!