Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5 Upgrade docs updated for flex_template_job, node_group, and import format regex #9045

Merged
merged 6 commits into from
Sep 25, 2023

Conversation

NickElliot
Copy link
Contributor

@NickElliot NickElliot commented Sep 21, 2023

flex_template: #9031
node_group: #9044
import regex: #8913

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 28 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 28 insertions(+), 1 deletion(-))

@NickElliot NickElliot marked this pull request as ready for review September 22, 2023 17:20
@NickElliot NickElliot requested a review from c2thorn September 22, 2023 17:20
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 29 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 29 insertions(+), 1 deletion(-))

@c2thorn c2thorn requested a review from rileykarson September 22, 2023 20:25
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewording suggestions inline

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 29 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 29 insertions(+), 1 deletion(-))

@NickElliot NickElliot requested a review from c2thorn September 22, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants