Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make labels field have all labels in data sources #9037

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Sep 21, 2023

Release Note Template for Downstream PRs (will be copied)

provider: made three fields `labels`, `terraform_labels`, and `effective_labels` be present in most resource-based datasources. All three fields will have all of labels present on the resource in GCP including the labels configured through Terraform, the system, and other clients, equivalent to `effective_labels` on the resource.
provider: made both `annotations` and `effective_annotations` be present in most resource-based datasources. Both fields will have all of annotations present on the resource in GCP including the annotations configured through Terraform, the system, and other clients, equivalent to `effective_annotations` on the resource.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 56 files changed, 217 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 58 files changed, 225 insertions(+), 27 deletions(-))

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{The provider crashed while running the VCR tests in REPLAYING mode}}$
$\textcolor{red}{\textsf{Please fix it to complete your PR}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 56 files changed, 219 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 58 files changed, 227 insertions(+), 27 deletions(-))

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{The provider crashed while running the VCR tests in REPLAYING mode}}$
$\textcolor{red}{\textsf{Please fix it to complete your PR}}$
View the build log

@zli82016 zli82016 force-pushed the datasource-labels branch 2 times, most recently from 37ac1fe to 13d8e87 Compare September 21, 2023 21:30
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 54 files changed, 210 insertions(+), 25 deletions(-))
Terraform Beta: Diff ( 56 files changed, 218 insertions(+), 25 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3068
Passed tests 2742
Skipped tests: 307
Affected tests: 19

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleBeyondcorpAppGateway_basic|TestAccDataSourceGoogleBeyondcorpAppConnector_optionalProjectRegion|TestAccDataSourceGoogleBeyondcorpAppConnection_basic|TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccDataSourceGoogleCloudFunctions2Function_basic|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleComputeDisk_basic|TestAccDataSourceGoogleForwardingRule|TestAccDataprocMetastoreServiceDatasource_basic|TestAccDataSourceGoogleFirebaseHostingChannel|TestAccDataSourcePrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccDataSourceGooglePubsubTopic_basic|TestAccDataSourceGooglePubsubSubscription_basic|TestAccRedisInstanceDatasource_basic|TestAccDataSourceGoogleProject_basic|TestAccDataSourceSecretManagerSecret_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleBeyondcorpAppGateway_basic[Debug log]
TestAccDataSourceGoogleBeyondcorpAppConnector_optionalProjectRegion[Debug log]
TestAccDataSourceGoogleBeyondcorpAppConnection_basic[Debug log]
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccDataSourceGoogleCloudFunctionsFunction_basic[Debug log]
TestAccDataSourceComposerEnvironment_basic[Debug log]
TestAccDataSourceGoogleGlobalForwardingRule[Debug log]
TestAccDataSourceGoogleComputeDisk_basic[Debug log]
TestAccDataSourceGoogleForwardingRule[Debug log]
TestAccDataprocMetastoreServiceDatasource_basic[Debug log]
TestAccDataSourceGoogleFirebaseHostingChannel[Debug log]
TestAccDataSourceGooglePubsubTopic_basic[Debug log]
TestAccDataSourceGooglePubsubSubscription_basic[Debug log]
TestAccRedisInstanceDatasource_basic[Debug log]
TestAccDataSourceGoogleProject_basic[Debug log]
TestAccDataSourceSecretManagerSecret_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGoogleCloudFunctions2Function_basic[Error message] [Debug log]
TestAccDataSourcePrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@zli82016 zli82016 force-pushed the datasource-labels branch 2 times, most recently from 34f8fe4 to 0863953 Compare September 22, 2023 00:29
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 54 files changed, 219 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 56 files changed, 227 insertions(+), 18 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3068
Passed tests 2760
Skipped tests: 307
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourcePrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourcePrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@zli82016 zli82016 requested a review from c2thorn September 22, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants