Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow google_monitoring_notification_channel import process to set project from the URI #9022

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

SarahFrench
Copy link
Collaborator

@SarahFrench SarahFrench commented Sep 20, 2023

Fixes hashicorp/terraform-provider-google#10788

This PR makes the import logic for the google_monitoring_notification_channel resource pull the project value out of the URI. This allows people to import the resource when there are no default project values present on the provider.

Release Note Template for Downstream PRs (will be copied)

monitoring: fixed bug where importing `google_monitoring_notification_channel` failed when no default project was supplied in provider configuration or through environment variables

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 13 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 13 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3075
Passed tests 2775
Skipped tests: 299
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@SarahFrench SarahFrench marked this pull request as ready for review September 21, 2023 16:04
@SarahFrench
Copy link
Collaborator Author

Thanks for the speedy review Hao!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import google_monitoring_notification_channel
3 participants