Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip duplication validation for empty cluster IDs #9018

Conversation

ron-gal
Copy link
Contributor

@ron-gal ron-gal commented Sep 20, 2023

Release Note Template for Downstream PRs (will be copied)

bigtable: fixed a bug where dynamically created clusters would incorrectly run into duplication error in `google_bigtable_instance`

Fixes hashicorp/terraform-provider-google#15771

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+))

@ron-gal ron-gal marked this pull request as ready for review September 20, 2023 14:06
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3075
Passed tests 2775
Skipped tests: 299
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the fix. Overall looks good. Have you tested locally and make sure that hashicorp/terraform-provider-google#15771 will be resolved by this fix?

Plus, I modified the changelog a bit. Please let me know if that makes sense.

@ron-gal
Copy link
Contributor Author

ron-gal commented Sep 21, 2023

Thanks for making the fix. Overall looks good. Have you tested locally and make sure that hashicorp/terraform-provider-google#15771 will be resolved by this fix?

Plus, I modified the changelog a bit. Please let me know if that makes sense.

Hey!
Tested locally, issue is resolved :)
Changelog looks good, thanks!

@SarahFrench
Copy link
Collaborator

Thank you for the fix on this edge case!

nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Sep 22, 2023
@ron-gal ron-gal deleted the skip_duplication_validation_for_empty_cluster_IDs branch July 8, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate cluster detection incorrectly flags cluster_id values that are being generated dynamically
4 participants