-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip duplication validation for empty cluster IDs #9018
Skip duplication validation for empty cluster IDs #9018
Conversation
Hello! I am a robot. It looks like you are a: @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the fix. Overall looks good. Have you tested locally and make sure that hashicorp/terraform-provider-google#15771 will be resolved by this fix?
Plus, I modified the changelog a bit. Please let me know if that makes sense.
Hey! |
Thank you for the fix on this edge case! |
Release Note Template for Downstream PRs (will be copied)
Fixes hashicorp/terraform-provider-google#15771