Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new labels model to more resources (part 3) #8982

Closed
wants to merge 1 commit into from

Conversation

zli82016
Copy link
Member

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field labels transitioned from optional+computed to optional google_vertex_ai_dataset - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 50 files changed, 1195 insertions(+), 340 deletions(-))
Terraform Beta: Diff ( 58 files changed, 1438 insertions(+), 408 deletions(-))
TF Conversion: Diff ( 17 files changed, 214 insertions(+), 214 deletions(-))
TF OiCS: Diff ( 3 files changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field labels transitioned from optional+computed to optional google_vertex_ai_dataset - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 53 files changed, 1205 insertions(+), 350 deletions(-))
Terraform Beta: Diff ( 63 files changed, 1457 insertions(+), 427 deletions(-))
TF Conversion: Diff ( 17 files changed, 214 insertions(+), 214 deletions(-))
TF OiCS: Diff ( 3 files changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3035
Passed tests 2719
Skipped tests: 304
Affected tests: 12

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPubsubSubscription_update|TestAccPubsubTopic_update|TestAccRedisInstance_update|TestAccVertexAIDataset_vertexAiDatasetExample|TestAccDataSourceVertexAIIndex_basic|TestAccVertexAIIndexEndpoint_updated|TestAccWorkflowsWorkflow_workflowBasicExample|TestAccWorkstationsWorkstationConfigIamBindingGenerated|TestAccWorkstationsWorkstationConfigIamPolicyGenerated|TestAccWorkstationsWorkstationConfigIamMemberGenerated|TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample|TestAccWorkstationsWorkstationConfig_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPubsubTopic_update[Debug log]
TestAccRedisInstance_update[Debug log]
TestAccVertexAIDataset_vertexAiDatasetExample[Debug log]
TestAccWorkflowsWorkflow_workflowBasicExample[Debug log]
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Debug log]
TestAccWorkstationsWorkstationConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPubsubSubscription_update[Error message] [Debug log]
TestAccDataSourceVertexAIIndex_basic[Error message] [Debug log]
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field labels transitioned from optional+computed to optional google_vertex_ai_dataset - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 54 files changed, 1217 insertions(+), 358 deletions(-))
Terraform Beta: Diff ( 64 files changed, 1469 insertions(+), 435 deletions(-))
TF Conversion: Diff ( 23 files changed, 336 insertions(+), 224 deletions(-))
TF OiCS: Diff ( 3 files changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3009
Passed tests 2704
Skipped tests: 304
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPubsubSubscription_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPubsubSubscription_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

@zli82016 zli82016 closed this Sep 18, 2023
@zli82016 zli82016 deleted the labels-mmv1-3 branch November 29, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants