-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply new labels model to more resources (part 2) #8980
Conversation
b16eddc
to
e82583b
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 98 files changed, 2174 insertions(+), 621 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 27 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRegionInstanceTemplate_imageShorthand|TestAccComputeRegionDisk_basicUpdate|TestAccComputeExternalVpnGateway_onlyExternalVpnGatewayFullExample|TestAccComputeInstanceTemplate_imageShorthand|TestAccComputeImage_update|TestAccComputeImage_withLicense|TestAccSnapshotDatasource_filterMostRecent|TestAccSnapshotDatasource_filter|TestAccSnapshotDatasource_name|TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample|TestAccDataprocMetastoreServiceIamMemberGenerated|TestAccDataprocMetastoreServiceIamBindingGenerated|TestAccDataprocMetastoreServiceIamPolicyGenerated|TestAccDialogflowCXIntent_update|TestAccFilestoreInstance_update|TestAccGKEHubMembershipIamMemberGenerated|TestAccGKEHubMembershipIamPolicyGenerated|TestAccGKEHubMembershipIamBindingGenerated|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccKmsCryptoKey_importOnly|TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkServicesMesh_update|TestAccNetworkServicesGateway_update|TestAccNetworkServicesEdgeCacheOrigin_updateAndImport|TestAccNetworkServicesEndpointPolicy_update|TestAccNetworkServicesHttpRoute_update |
Rerun these tests in REPLAYING mode to catch issues
|
e82583b
to
246257a
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 99 files changed, 2190 insertions(+), 633 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRegionInstanceTemplate_imageShorthand|TestAccComputeInstanceTemplate_imageShorthand|TestAccComputeImage_update|TestAccComputeImage_withLicense|TestAccComputeExternalVpnGateway_onlyExternalVpnGatewayFullExample|TestAccSnapshotDatasource_filterMostRecent|TestAccSnapshotDatasource_filter|TestAccSnapshotDatasource_name |
|
246257a
to
13be27b
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 102 files changed, 2193 insertions(+), 642 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstanceTemplate_imageShorthand|TestAccComputeImage_update|TestAccComputeImage_withLicense|TestAccComputeExternalVpnGateway_onlyExternalVpnGatewayFullExample|TestAccComputeRegionInstanceTemplate_imageShorthand |
Rerun these tests in REPLAYING mode to catch issues
|
13be27b
to
ced30ad
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 156 files changed, 3410 insertions(+), 1000 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 156 files changed, 3410 insertions(+), 1000 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy|TestAccPubsubSubscription_update|TestAccPubsubTopic_update|TestAccRedisInstance_update|TestAccVertexAIDataset_vertexAiDatasetExample|TestAccVertexAIIndexEndpoint_updated|TestAccWorkflowsWorkflow_workflowBasicExample|TestAccWorkstationsWorkstationConfigIamPolicyGenerated|TestAccWorkstationsWorkstationConfigIamMemberGenerated|TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample|TestAccWorkstationsWorkstationConfigIamBindingGenerated|TestAccWorkstationsWorkstationConfig_update |
Rerun these tests in REPLAYING mode to catch issues
|
The failed test is unrelated. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 156 files changed, 3410 insertions(+), 1000 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIIndexEndpoint_updated |
|
Release Note Template for Downstream PRs (will be copied)