Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new labels model to more resources (part 2) #8980

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

zli82016
Copy link
Member

Release Note Template for Downstream PRs (will be copied)


@zli82016 zli82016 force-pushed the labels-mmv1-2 branch 2 times, most recently from b16eddc to e82583b Compare September 17, 2023 00:34
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 98 files changed, 2174 insertions(+), 621 deletions(-))
Terraform Beta: Diff ( 125 files changed, 2992 insertions(+), 921 deletions(-))
TF Conversion: Diff ( 34 files changed, 462 insertions(+), 462 deletions(-))
TF OiCS: Diff ( 4 files changed, 15 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3035
Passed tests 2704
Skipped tests: 304
Affected tests: 27

Action taken

Found 27 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionInstanceTemplate_imageShorthand|TestAccComputeRegionDisk_basicUpdate|TestAccComputeExternalVpnGateway_onlyExternalVpnGatewayFullExample|TestAccComputeInstanceTemplate_imageShorthand|TestAccComputeImage_update|TestAccComputeImage_withLicense|TestAccSnapshotDatasource_filterMostRecent|TestAccSnapshotDatasource_filter|TestAccSnapshotDatasource_name|TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample|TestAccDataprocMetastoreServiceIamMemberGenerated|TestAccDataprocMetastoreServiceIamBindingGenerated|TestAccDataprocMetastoreServiceIamPolicyGenerated|TestAccDialogflowCXIntent_update|TestAccFilestoreInstance_update|TestAccGKEHubMembershipIamMemberGenerated|TestAccGKEHubMembershipIamPolicyGenerated|TestAccGKEHubMembershipIamBindingGenerated|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccKmsCryptoKey_importOnly|TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkServicesMesh_update|TestAccNetworkServicesGateway_update|TestAccNetworkServicesEdgeCacheOrigin_updateAndImport|TestAccNetworkServicesEndpointPolicy_update|TestAccNetworkServicesHttpRoute_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample[Debug log]
TestAccDataprocMetastoreServiceIamMemberGenerated[Debug log]
TestAccDataprocMetastoreServiceIamBindingGenerated[Debug log]
TestAccDataprocMetastoreServiceIamPolicyGenerated[Debug log]
TestAccFilestoreInstance_update[Debug log]
TestAccGKEHubMembershipIamMemberGenerated[Debug log]
TestAccGKEHubMembershipIamPolicyGenerated[Debug log]
TestAccGKEHubMembershipIamBindingGenerated[Debug log]
TestAccGKEHubMembership_gkehubMembershipBasicExample[Debug log]
TestAccMemcacheInstance_memcacheInstanceBasicExample[Debug log]
TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample[Debug log]
TestAccNetworkServicesMesh_update[Debug log]
TestAccNetworkServicesGateway_update[Debug log]
TestAccNetworkServicesEdgeCacheOrigin_updateAndImport[Debug log]
TestAccNetworkServicesEndpointPolicy_update[Debug log]
TestAccNetworkServicesHttpRoute_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeRegionInstanceTemplate_imageShorthand[Error message] [Debug log]
TestAccComputeRegionDisk_basicUpdate[Error message] [Debug log]
TestAccComputeExternalVpnGateway_onlyExternalVpnGatewayFullExample[Error message] [Debug log]
TestAccComputeInstanceTemplate_imageShorthand[Error message] [Debug log]
TestAccComputeImage_update[Error message] [Debug log]
TestAccComputeImage_withLicense[Error message] [Debug log]
TestAccSnapshotDatasource_filterMostRecent[Error message] [Debug log]
TestAccSnapshotDatasource_filter[Error message] [Debug log]
TestAccSnapshotDatasource_name[Error message] [Debug log]
TestAccDialogflowCXIntent_update[Error message] [Debug log]
TestAccKmsCryptoKey_importOnly[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 99 files changed, 2190 insertions(+), 633 deletions(-))
Terraform Beta: Diff ( 126 files changed, 3008 insertions(+), 933 deletions(-))
TF Conversion: Diff ( 34 files changed, 462 insertions(+), 462 deletions(-))
TF OiCS: Diff ( 4 files changed, 15 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3035
Passed tests 2723
Skipped tests: 304
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionInstanceTemplate_imageShorthand|TestAccComputeInstanceTemplate_imageShorthand|TestAccComputeImage_update|TestAccComputeImage_withLicense|TestAccComputeExternalVpnGateway_onlyExternalVpnGatewayFullExample|TestAccSnapshotDatasource_filterMostRecent|TestAccSnapshotDatasource_filter|TestAccSnapshotDatasource_name

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeRegionInstanceTemplate_imageShorthand[Error message] [Debug log]
TestAccComputeInstanceTemplate_imageShorthand[Error message] [Debug log]
TestAccComputeImage_update[Error message] [Debug log]
TestAccComputeImage_withLicense[Error message] [Debug log]
TestAccComputeExternalVpnGateway_onlyExternalVpnGatewayFullExample[Error message] [Debug log]
TestAccSnapshotDatasource_filterMostRecent[Error message] [Debug log]
TestAccSnapshotDatasource_filter[Error message] [Debug log]
TestAccSnapshotDatasource_name[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 102 files changed, 2193 insertions(+), 642 deletions(-))
Terraform Beta: Diff ( 129 files changed, 3011 insertions(+), 942 deletions(-))
TF Conversion: Diff ( 34 files changed, 462 insertions(+), 462 deletions(-))
TF OiCS: Diff ( 5 files changed, 15 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3035
Passed tests 2726
Skipped tests: 304
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceTemplate_imageShorthand|TestAccComputeImage_update|TestAccComputeImage_withLicense|TestAccComputeExternalVpnGateway_onlyExternalVpnGatewayFullExample|TestAccComputeRegionInstanceTemplate_imageShorthand

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceTemplate_imageShorthand[Debug log]
TestAccComputeImage_update[Debug log]
TestAccComputeImage_withLicense[Debug log]
TestAccComputeExternalVpnGateway_onlyExternalVpnGatewayFullExample[Debug log]
TestAccComputeRegionInstanceTemplate_imageShorthand[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field labels transitioned from optional+computed to optional google_vertex_ai_dataset - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 156 files changed, 3410 insertions(+), 1000 deletions(-))
Terraform Beta: Diff ( 193 files changed, 4480 insertions(+), 1377 deletions(-))
TF Conversion: Diff ( 60 files changed, 851 insertions(+), 689 deletions(-))
TF OiCS: Diff ( 8 files changed, 26 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field labels transitioned from optional+computed to optional google_vertex_ai_dataset - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 156 files changed, 3410 insertions(+), 1000 deletions(-))
Terraform Beta: Diff ( 193 files changed, 4480 insertions(+), 1377 deletions(-))
TF Conversion: Diff ( 60 files changed, 851 insertions(+), 689 deletions(-))
TF OiCS: Diff ( 8 files changed, 26 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3035
Passed tests 2719
Skipped tests: 304
Affected tests: 12

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocClusterIamPolicy|TestAccPubsubSubscription_update|TestAccPubsubTopic_update|TestAccRedisInstance_update|TestAccVertexAIDataset_vertexAiDatasetExample|TestAccVertexAIIndexEndpoint_updated|TestAccWorkflowsWorkflow_workflowBasicExample|TestAccWorkstationsWorkstationConfigIamPolicyGenerated|TestAccWorkstationsWorkstationConfigIamMemberGenerated|TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample|TestAccWorkstationsWorkstationConfigIamBindingGenerated|TestAccWorkstationsWorkstationConfig_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]
TestAccPubsubSubscription_update[Debug log]
TestAccPubsubTopic_update[Debug log]
TestAccRedisInstance_update[Debug log]
TestAccVertexAIDataset_vertexAiDatasetExample[Debug log]
TestAccWorkflowsWorkflow_workflowBasicExample[Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Debug log]
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Debug log]
TestAccWorkstationsWorkstationConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@zli82016
Copy link
Member Author

The failed test is unrelated.

@zli82016
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field labels transitioned from optional+computed to optional google_vertex_ai_dataset - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 156 files changed, 3410 insertions(+), 1000 deletions(-))
Terraform Beta: Diff ( 193 files changed, 4480 insertions(+), 1377 deletions(-))
TF Conversion: Diff ( 60 files changed, 851 insertions(+), 689 deletions(-))
TF OiCS: Diff ( 8 files changed, 26 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3035
Passed tests 2730
Skipped tests: 304
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccVertexAIIndexEndpoint_updated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVertexAIIndexEndpoint_updated[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@zli82016 zli82016 merged commit d6b01a2 into FEATURE-BRANCH-major-release-5.0.0 Sep 18, 2023
7 checks passed
@zli82016 zli82016 deleted the labels-mmv1-2 branch September 18, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants