Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workstations): add env block in google_workstations_workstation #8911

Merged
merged 1 commit into from
Sep 12, 2023
Merged

feat(workstations): add env block in google_workstations_workstation #8911

merged 1 commit into from
Sep 12, 2023

Conversation

ch3ck
Copy link
Contributor

@ch3ck ch3ck commented Sep 10, 2023

Description

Support env block on the google_workstations_workstation resource.

Fixes #15660

Release Note Template for Downstream PRs (will be copied)

workstations: added `env` field to `google_workstations_workstation` resource (beta)

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 10, 2023
@ch3ck ch3ck marked this pull request as ready for review September 10, 2023 22:13
@ch3ck ch3ck changed the title feat: add env block in google_workstations_workstation feat(workstations): add env block in google_workstations_workstation Sep 11, 2023
@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 11, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 8 insertions(+))
Terraform Beta: Diff ( 5 files changed, 80 insertions(+))
TF Conversion: Diff ( 1 file changed, 17 insertions(+))
TF OiCS: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3026
Passed tests 2723
Skipped tests: 297
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccWorkstationsWorkstationIamMemberGenerated|TestAccWorkstationsWorkstation_update|TestAccWorkstationsWorkstation_workstationBasicExample|TestAccWorkstationsWorkstationIamPolicyGenerated|TestAccWorkstationsWorkstationIamBindingGenerated

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]
TestAccWorkstationsWorkstationIamMemberGenerated[Debug log]
TestAccWorkstationsWorkstation_update[Debug log]
TestAccWorkstationsWorkstation_workstationBasicExample[Debug log]
TestAccWorkstationsWorkstationIamPolicyGenerated[Debug log]
TestAccWorkstationsWorkstationIamBindingGenerated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@ch3ck
Copy link
Contributor Author

ch3ck commented Sep 12, 2023

Hey @c2thorn @melinath @rileykarson @roaks3 , can someone review this?

@zli82016
Copy link
Member

Sorry, @ch3ck , I am reviewing this now.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 12, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 8 insertions(+))
Terraform Beta: Diff ( 5 files changed, 80 insertions(+))
TF Conversion: Diff ( 1 file changed, 17 insertions(+))
TF OiCS: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3037
Passed tests 2739
Skipped tests: 297
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccWorkstationsWorkstation_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccWorkstationsWorkstation_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support env block in google_workstations_workstation
3 participants