-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workstations): add env block in google_workstations_workstation #8911
feat(workstations): add env block in google_workstations_workstation #8911
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 8 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccWorkstationsWorkstationIamMemberGenerated|TestAccWorkstationsWorkstation_update|TestAccWorkstationsWorkstation_workstationBasicExample|TestAccWorkstationsWorkstationIamPolicyGenerated|TestAccWorkstationsWorkstationIamBindingGenerated |
Rerun these tests in REPLAYING mode to catch issues
|
Hey @c2thorn @melinath @rileykarson @roaks3 , can someone review this? |
Sorry, @ch3ck , I am reviewing this now. |
mmv1/third_party/terraform/services/workstations/resource_workstations_workstation_test.go.erb
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 8 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccWorkstationsWorkstation_update |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Description
Support
env
block on thegoogle_workstations_workstation
resource.Fixes #15660
Release Note Template for Downstream PRs (will be copied)