compute/backend_service: Remove TTLs when using cache mode USE_ORIGIN_HEADERS

[IchordeDionysos]

Removes TTLs when using cache_mode = "USE_ORIGIN_HEADERS" which would otherwise result in API validation errors.

Fixes hashicorp/terraform-provider-google#15791

Replicates the changes from this PR #7588 which fixed it for google_compute_backend_bucket.

Release Note Template for Downstream PRs (will be copied)

compute: fixed an issue with TTLs being sent for `google_compute_backend_service` when `cache_mode` is set to `USE_ORIGIN_HEADERS`

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 39 insertions(+))
Terraform Beta: Diff ( 1 file changed, 39 insertions(+))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3026
Passed tests 2729
Skipped tests: 297
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[IchordeDionysos]

@rileykarson do you have an update here? Is there anything I should add or change?

[IchordeDionysos]

@rileykarson , I understand you are working a lot on the 5.0.0 release, and I hope it gets released soon, as it fixes another annoying issue we have right now.

However, can you give me some clarity on when you get to review this PR? Will it only be after the 5.0.0 release (which already had been pushed back)?

[rileykarson]

Sorry for the delay on my end! 5.0.0 was part of why it took me a while to get to this, I was busy with some other time-sensitive work as well. google_compute_backend_service tends to be finicky (and a case like this is exactly one of the places where it gets the most finicky) and I didn't have the time to review it properly.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 39 insertions(+))
Terraform Beta: Diff ( 2 files changed, 72 insertions(+))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3119
Passed tests 2799
Skipped tests: 318
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeBackendService_withCdnPolicy|TestAccWorkstationsWorkstationConfig_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeBackendService_withCdnPolicy[Debug log]
TestAccWorkstationsWorkstationConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[IchordeDionysos]

@rileykarson, what does it mean that those tests fail?

[IchordeDionysos]

@rileykarson how can we move this PR forward? :)

[rileykarson]

LGTM- just running the tests again to validate.

Sorry for the delay- had to have enough to sit down and think through the default values comment.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 201 insertions(+))
Terraform Beta: Diff ( 2 files changed, 72 insertions(+))
TF Conversion: Diff ( 1 file changed, 39 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3146
Passed tests 2828
Skipped tests: 316
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbCluster_secondaryClusterMandatoryFields

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAlloydbBackup_alloydbBackupFullExample[Error message] [Debug log]
TestAccAlloydbCluster_secondaryClusterMandatoryFields[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[IchordeDionysos]

@rileykarson we can ignore those test failures as they are unrelated to this PR right?