Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 upgrade docs updated for Default Provider Values and Data Source 404 erroring #8903

Merged
merged 3 commits into from
Sep 11, 2023
Merged

V5 upgrade docs updated for Default Provider Values and Data Source 404 erroring #8903

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53f573e
docs update
NickElliot Sep 8, 2023
6e6bb4c
Update version_5_upgrade.html.markdown
NickElliot Sep 11, 2023
ccba719
Update version_5_upgrade.html.markdown
NickElliot Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,16 @@ The new annotations model is similar to the new labels model and will be applied

There are now two annotation-related fields with the new model, the `annotations` and the output-only `effective_annotations` fields.

### Provider default values shown at plan-time

`project`, `region`, and `zone` fields will now display their values during plan-time instead of the placeholder `(known after apply)` value normally displayed for fields without fixed default values. These values will be taken from either the Terraform resource config file, provider config, or local environment variables, depending on which variables are supplied by the user, matching the existing per-resource functionality for what default values are used in execution of a Terraform plan.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`project`, `region`, and `zone` fields will now display their values during plan-time instead of the placeholder `(known after apply)` value normally displayed for fields without fixed default values. These values will be taken from either the Terraform resource config file, provider config, or local environment variables, depending on which variables are supplied by the user, matching the existing per-resource functionality for what default values are used in execution of a Terraform plan.
`project`, `region`, and `zone` fields will now display their values during plan-time instead of the placeholder `(known after apply)` value normally displayed for fields without provider default values. These values will be taken from either the Terraform resource config file, provider config, or local environment variables, depending on which variables are supplied by the user, matching the existing per-resource functionality for what default values are used in execution of a Terraform plan.

I understand fixed != API value here, but might as well be specific?

Copy link
Contributor Author

@NickElliot NickElliot Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is it conflicts with the other usage of provider as a term -- since it does use the "provder default" value, as in what is configured in the user's provider config. I thought about saying "universal default", "hard-coded default", or similar to mean "regardless of local configuration", but wasn't sure if that became more or less clear than "fixed" on its own

Copy link
Member

@c2thorn c2thorn Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. How about "fixed Terraform default values" ? If not, I'm fine with just "fixed". Users that care will probably already understand from the (known after apply) part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me!


## Datasources

### Datasources now error universally on 404

All data sources have been updated to return an error when a target resource URI can not be reached. Previously this was inconsistent between different datasources in whether an empty value was returned to Terraform state upon 404 or if an error was returned, but this has been standardized. Any plans that reference datasources which no longer exist (or do not exist yet) will need to be revised to have these datasources removed from configuration files.

## Datasource: `google_product_datasource`

### Datasource-level change example header
Expand Down Expand Up @@ -437,4 +445,4 @@ resource "google_project_iam_binding" "gcs-bucket-writer" {

### `Create` endpoint is used to create the resource

`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved.
`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved.