Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support provider default labels for DCL resources #8893

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Sep 7, 2023

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 43 files changed, 1029 insertions(+), 702 deletions(-))
Terraform Beta: Diff ( 43 files changed, 1113 insertions(+), 798 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3008
Passed tests 2672
Skipped tests: 302
Affected tests: 34

Action taken

Found 34 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccCloudbuildv2Connection_GleOldConnection|TestAccCloudbuildv2Repository_GithubRepository|TestAccCloudbuildv2Connection_GitlabConnection|TestAccCloudbuildv2Connection_GithubConnection|TestAccCloudbuildv2Connection_GleConnection|TestAccCloudbuildv2Connection_GheCompleteConnection|TestAccCloudbuildv2Repository_GheRepository|TestAccCloudbuildv2Repository_GitlabRepository|TestAccCloudbuildv2Connection_GheConnection|TestAccCloudbuildv2Repository_GleRepository|TestAccCloudbuildv2Connection_GhePrivUpdateConnection|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccCloudbuildv2Connection_GhePrivConnection|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccClouddeployTarget_MultiTarget|TestAccClouddeployTarget_RunTarget|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccClouddeployDeliveryPipeline_VerifyDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccClouddeployTarget_Target|TestAccDataplexLake_BasicLake|TestAccDataplexZone_BasicZone|TestAccDataprocJobIamPolicy|TestAccDataprocWorkflowTemplate_basic|TestAccNetworkConnectivityHub_BasicHub|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccRecaptchaEnterpriseKey_AndroidKey|TestAccRecaptchaEnterpriseKey_IosKey|TestAccRecaptchaEnterpriseKey_MinimalKey|TestAccRecaptchaEnterpriseKey_WebKey|TestAccRecaptchaEnterpriseKey_WebScoreKey|TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudbuildv2Connection_GlePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleOldConnection[Error message] [Debug log]
TestAccCloudbuildv2Repository_GithubRepository[Error message] [Debug log]
TestAccCloudbuildv2Connection_GitlabConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GithubConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GheCompleteConnection[Error message] [Debug log]
TestAccCloudbuildv2Repository_GheRepository[Error message] [Debug log]
TestAccCloudbuildv2Repository_GitlabRepository[Error message] [Debug log]
TestAccCloudbuildv2Connection_GheConnection[Error message] [Debug log]
TestAccCloudbuildv2Repository_GleRepository[Error message] [Debug log]
TestAccCloudbuildv2Connection_GhePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GhePrivConnection[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Error message] [Debug log]
TestAccClouddeployTarget_MultiTarget[Error message] [Debug log]
TestAccClouddeployTarget_RunTarget[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_VerifyDeliveryPipeline[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline[Error message] [Debug log]
TestAccClouddeployTarget_Target[Error message] [Debug log]
TestAccDataplexLake_BasicLake[Error message] [Debug log]
TestAccDataplexZone_BasicZone[Error message] [Debug log]
TestAccDataprocWorkflowTemplate_basic[Error message] [Debug log]
TestAccNetworkConnectivityHub_BasicHub[Error message] [Debug log]
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_AndroidKey[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_IosKey[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_MinimalKey[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_WebKey[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_WebScoreKey[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 44 files changed, 1142 insertions(+), 839 deletions(-))
Terraform Beta: Diff ( 44 files changed, 1323 insertions(+), 1041 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3008
Passed tests 2690
Skipped tests: 302
Affected tests: 16

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccClouddeployTarget_MultiTarget|TestAccClouddeployDeliveryPipeline_VerifyDeliveryPipeline|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccClouddeployTarget_Target|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccClouddeployTarget_RunTarget|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccDataplexLake_BasicLake|TestAccDataplexZone_BasicZone|TestAccNetworkConnectivityHub_BasicHub|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccRecaptchaEnterpriseKey_AndroidKey|TestAccRecaptchaEnterpriseKey_WebScoreKey|TestAccRecaptchaEnterpriseKey_IosKey|TestAccRecaptchaEnterpriseKey_WebKey

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccClouddeployTarget_MultiTarget[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_VerifyDeliveryPipeline[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Error message] [Debug log]
TestAccClouddeployTarget_Target[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline[Error message] [Debug log]
TestAccClouddeployTarget_RunTarget[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline[Error message] [Debug log]
TestAccDataplexLake_BasicLake[Error message] [Debug log]
TestAccDataplexZone_BasicZone[Error message] [Debug log]
TestAccNetworkConnectivityHub_BasicHub[Error message] [Debug log]
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_AndroidKey[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_WebScoreKey[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_IosKey[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_WebKey[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 44 files changed, 1144 insertions(+), 839 deletions(-))
Terraform Beta: Diff ( 44 files changed, 1325 insertions(+), 1041 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3008
Passed tests 2690
Skipped tests: 302
Affected tests: 16

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccClouddeployDeliveryPipeline_VerifyDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccClouddeployTarget_MultiTarget|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccClouddeployTarget_RunTarget|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline|TestAccClouddeployTarget_Target|TestAccDataplexLake_BasicLake|TestAccDataplexZone_BasicZone|TestAccNetworkConnectivityHub_BasicHub|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccRecaptchaEnterpriseKey_AndroidKey|TestAccRecaptchaEnterpriseKey_IosKey|TestAccRecaptchaEnterpriseKey_WebScoreKey|TestAccRecaptchaEnterpriseKey_WebKey

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccClouddeployDeliveryPipeline_VerifyDeliveryPipeline[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline[Error message] [Debug log]
TestAccClouddeployTarget_MultiTarget[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Error message] [Debug log]
TestAccClouddeployTarget_RunTarget[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline[Error message] [Debug log]
TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline[Error message] [Debug log]
TestAccClouddeployTarget_Target[Error message] [Debug log]
TestAccDataplexLake_BasicLake[Error message] [Debug log]
TestAccDataplexZone_BasicZone[Error message] [Debug log]
TestAccNetworkConnectivityHub_BasicHub[Error message] [Debug log]
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_AndroidKey[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_IosKey[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_WebScoreKey[Error message] [Debug log]
TestAccRecaptchaEnterpriseKey_WebKey[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 44 files changed, 1168 insertions(+), 863 deletions(-))
Terraform Beta: Diff ( 44 files changed, 1361 insertions(+), 1077 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3008
Passed tests 2705
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountAccessToken_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountAccessToken_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 46 files changed, 1547 insertions(+), 863 deletions(-))
Terraform Beta: Diff ( 46 files changed, 1740 insertions(+), 1077 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3009
Passed tests 2703
Skipped tests: 303
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountJwt|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccSpannerInstanceIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]
TestAccSpannerInstanceIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 45 files changed, 1449 insertions(+), 861 deletions(-))
Terraform Beta: Diff ( 45 files changed, 1642 insertions(+), 1075 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 45 files changed, 1449 insertions(+), 861 deletions(-))
Terraform Beta: Diff ( 45 files changed, 1642 insertions(+), 1075 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3009
Passed tests 2703
Skipped tests: 303
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@zli82016 zli82016 merged commit 75dcc62 into FEATURE-BRANCH-major-release-5.0.0 Sep 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants