Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_logging_metric to version 5 upgrade doc for #8780 #8887

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

pengq-google
Copy link
Contributor

@pengq-google pengq-google commented Sep 7, 2023

Add google_logging_metric to version 5 upgrade doc for #8780

Release Note Template for Downstream PRs (will be copied)

Add google_logging_metric to version 5 upgrade doc for #8780

@pengq-google
Copy link
Contributor Author

@c2thorn Thanks! :)

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@pengq-google
Copy link
Contributor Author

Sorry I am not quite sure why it is still some conflicts. Is it ok that I can revisit it tomorrow? I have another office hour with your Terraform team. Thank you and your team so much!

@c2thorn
Copy link
Member

c2thorn commented Sep 7, 2023

Sorry I am not quite sure why it is still some conflicts. Is it ok that I can revisit it tomorrow? I have another office hour with your Terraform team. Thank you and your team so much!

There may be multiple commits simultaneously that are being merged, it's a busy time for that file. Copying your text, pulling from the main branch, then adding your text should ensure no conflicts (for the time being). You can also go to the file here: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown and just hit the edit button from the browser

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 13 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 18 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 13 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 13 insertions(+), 1 deletion(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants