-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google_logging_metric to version 5 upgrade doc for #8780 #8887
Conversation
@c2thorn Thanks! :) |
Hello! I am a robot. It looks like you are a: @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Sorry I am not quite sure why it is still some conflicts. Is it ok that I can revisit it tomorrow? I have another office hour with your Terraform team. Thank you and your team so much! |
There may be multiple commits simultaneously that are being merged, it's a busy time for that file. Copying your text, pulling from the |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 13 insertions(+), 1 deletion(-)) |
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
…de.html.markdown Co-authored-by: Cameron Thornton <[email protected]>
…de.html.markdown Co-authored-by: Cameron Thornton <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 13 insertions(+), 1 deletion(-)) |
…tform#8780 (GoogleCloudPlatform#8887) Co-authored-by: Cameron Thornton <[email protected]>
…tform#8780 (GoogleCloudPlatform#8887) Co-authored-by: Cameron Thornton <[email protected]>
Add google_logging_metric to version 5 upgrade doc for #8780
Release Note Template for Downstream PRs (will be copied)